Issue 10637003: Correctly support several consecutive stack modifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10637003: Correctly support several consecutive stack modifications. (Closed)

Created:
8 years, 6 months ago by Peter Rybin

Modified:
8 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Correctly support several consecutive stack modifications. Committed: https://code.google.com/p/v8/source/detail?r=11914

Patch Set 1 #

Patch Set 2 : style #

Total comments: 2

Patch Set 3 : follow codereview #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -78 lines)			Patch
M	src/debug.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/debug.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/liveedit.cc	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
A +	test/mjsunit/debug-liveedit-double-call.js	View	1 2	3 chunks	+64 lines, -75 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 6 months ago (2012-06-22 08:13:23 UTC) #3

http://codereview.chromium.org/10637003/diff/1001/test/mjsunit/debug-liveedit...
File test/mjsunit/debug-liveedit-double-call.js (right):

http://codereview.chromium.org/10637003/diff/1001/test/mjsunit/debug-liveedit...
test/mjsunit/debug-liveedit-double-call.js:1: // Copyright 2010 the V8 project
authors. All rights reserved.
Update to 2012.

http://codereview.chromium.org/10637003/diff/1001/test/mjsunit/debug-liveedit...
test/mjsunit/debug-liveedit-double-call.js:97:
Debug.LiveEdit.SetScriptSource(script, script_text_generator.get(), false, []);
80 char limit.

Expand Messages | Collapse Messages