src/debug.cc - Issue 10637003: Correctly support several consecutive stack modifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 10637003: Correctly support several consecutive stack modifications. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: follow codereview Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 67d47c04e06373051b508f2e41c5051e5e2fe088..d3707667c4c9ff2a8a7b2fc8e73ef8b491355f39 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -2317,7 +2317,9 @@ bool Debug::IsBreakAtReturn(JavaScriptFrame* frame) {

void Debug::FramesHaveBeenDropped(StackFrame::Id new_break_frame_id,

FrameDropMode mode,

Object** restarter_frame_function_pointer) {

- thread_local_.frame_drop_mode_ = mode;

+ if (mode != CURRENTLY_SET_MODE) {

+ thread_local_.frame_drop_mode_ = mode;

+ }

thread_local_.break_frame_id_ = new_break_frame_id;

thread_local_.restarter_frame_function_pointer_ =

restarter_frame_function_pointer;

« no previous file with comments | « src/debug.h ('k') | src/liveedit.cc » ('j') | no next file with comments »