Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/debug.h

Issue 10637003: Correctly support several consecutive stack modifications. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: follow codereview Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 // No frame has been dropped. 439 // No frame has been dropped.
440 FRAMES_UNTOUCHED, 440 FRAMES_UNTOUCHED,
441 // The top JS frame had been calling IC stub. IC stub mustn't be called now. 441 // The top JS frame had been calling IC stub. IC stub mustn't be called now.
442 FRAME_DROPPED_IN_IC_CALL, 442 FRAME_DROPPED_IN_IC_CALL,
443 // The top JS frame had been calling debug break slot stub. Patch the 443 // The top JS frame had been calling debug break slot stub. Patch the
444 // address this stub jumps to in the end. 444 // address this stub jumps to in the end.
445 FRAME_DROPPED_IN_DEBUG_SLOT_CALL, 445 FRAME_DROPPED_IN_DEBUG_SLOT_CALL,
446 // The top JS frame had been calling some C++ function. The return address 446 // The top JS frame had been calling some C++ function. The return address
447 // gets patched automatically. 447 // gets patched automatically.
448 FRAME_DROPPED_IN_DIRECT_CALL, 448 FRAME_DROPPED_IN_DIRECT_CALL,
449 FRAME_DROPPED_IN_RETURN_CALL 449 FRAME_DROPPED_IN_RETURN_CALL,
450 CURRENTLY_SET_MODE
450 }; 451 };
451 452
452 void FramesHaveBeenDropped(StackFrame::Id new_break_frame_id, 453 void FramesHaveBeenDropped(StackFrame::Id new_break_frame_id,
453 FrameDropMode mode, 454 FrameDropMode mode,
454 Object** restarter_frame_function_pointer); 455 Object** restarter_frame_function_pointer);
455 456
456 // Initializes an artificial stack frame. The data it contains is used for: 457 // Initializes an artificial stack frame. The data it contains is used for:
457 // a. successful work of frame dropper code which eventually gets control, 458 // a. successful work of frame dropper code which eventually gets control,
458 // b. being compatible with regular stack structure for various stack 459 // b. being compatible with regular stack structure for various stack
459 // iterators. 460 // iterators.
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
1041 1042
1042 DISALLOW_COPY_AND_ASSIGN(MessageDispatchHelperThread); 1043 DISALLOW_COPY_AND_ASSIGN(MessageDispatchHelperThread);
1043 }; 1044 };
1044 1045
1045 1046
1046 } } // namespace v8::internal 1047 } } // namespace v8::internal
1047 1048
1048 #endif // ENABLE_DEBUGGER_SUPPORT 1049 #endif // ENABLE_DEBUGGER_SUPPORT
1049 1050
1050 #endif // V8_DEBUG_H_ 1051 #endif // V8_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698