Add a presubmit check to stop any more usages of harmful browser::Find* methods while we work throu…

Add a presubmit check to stop any more usages of harmful browser::Find* methods while we work through the existing list.

BUG=129187
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144245

[jam, 2012-06-26 18:25:06]

reused _CheckNoBannedFunctions, ->Avi

[Avi (use Gerrit), 2012-06-26 18:42:58]

http://codereview.chromium.org/10636058/diff/1002/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/10636058/diff/1002/PRESUBMIT.py#newcode128
PRESUBMIT.py:128: True,
Wow. OK.

http://codereview.chromium.org/10636058/diff/1002/PRESUBMIT.py#newcode179
PRESUBMIT.py:179: 'id. Talk to ben@ or jam@ for more information.',
I think I screwed up in porting to _BANNED_CPP_FUNCTIONS. Each of these strings
should not end in a space, and there should be a comma at the end of each line.
Can you fix yours and the ones I put in there too?

[jam, 2012-06-26 19:31:33]

http://codereview.chromium.org/10636058/diff/1002/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/10636058/diff/1002/PRESUBMIT.py#newcode128
PRESUBMIT.py:128: True,
On 2012/06/26 18:42:58, Avi wrote:
> Wow. OK.

why are you surprised? We don't want any more of these.

http://codereview.chromium.org/10636058/diff/1002/PRESUBMIT.py#newcode179
PRESUBMIT.py:179: 'id. Talk to ben@ or jam@ for more information.',
On 2012/06/26 18:42:58, Avi wrote:
> I think I screwed up in porting to _BANNED_CPP_FUNCTIONS. Each of these
strings
> should not end in a space, and there should be a comma at the end of each
line.
> Can you fix yours and the ones I put in there too?

Done.

[Avi (use Gerrit), 2012-06-26 19:49:57]

lgtm