Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: PRESUBMIT.py

Issue 10636058: Add a presubmit check to stop any more usages of harmful browser::Find* methods while we work throu… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py (revision 144105)
+++ PRESUBMIT.py (working copy)
@@ -114,7 +114,7 @@
(
'FRIEND_TEST(',
(
- 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include'
+ 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include',
'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.',
),
False,
@@ -122,19 +122,64 @@
(
'ScopedAllowIO',
(
- 'New code should not use ScopedAllowIO. Post a task to the blocking pool'
- 'or the FILE thread instead.',
+ 'New code should not use ScopedAllowIO. Post a task to the blocking',
+ 'pool or the FILE thread instead.',
),
- False,
+ True,
),
(
'FilePathWatcher::Delegate',
(
- 'New code should not use FilePathWatcher::Delegate. Use the callback'
+ 'New code should not use FilePathWatcher::Delegate. Use the callback',
'interface instead.',
),
False,
),
+ (
+ 'browser::FindLastActiveWithProfile',
+ (
+ 'This function is deprecated and we\'re working on removing it. Pass',
+ 'more context to get a Browser*, like a WebContents, window, or session',
+ 'id. Talk to ben@ or jam@ for more information.',
+ ),
+ True,
+ ),
+ (
+ 'browser::FindBrowserWithProfile',
+ (
+ 'This function is deprecated and we\'re working on removing it. Pass',
+ 'more context to get a Browser*, like a WebContents, window, or session',
+ 'id. Talk to ben@ or jam@ for more information.',
+ ),
+ True,
+ ),
+ (
+ 'browser::FindAnyBrowser',
+ (
+ 'This function is deprecated and we\'re working on removing it. Pass',
+ 'more context to get a Browser*, like a WebContents, window, or session',
+ 'id. Talk to ben@ or jam@ for more information.',
+ ),
+ True,
+ ),
+ (
+ 'browser::FindOrCreateTabbedBrowser',
+ (
+ 'This function is deprecated and we\'re working on removing it. Pass',
+ 'more context to get a Browser*, like a WebContents, window, or session',
+ 'id. Talk to ben@ or jam@ for more information.',
+ ),
+ True,
+ ),
+ (
+ 'browser::FindTabbedBrowser',
+ (
+ 'This function is deprecated and we\'re working on removing it. Pass',
+ 'more context to get a Browser*, like a WebContents, window, or session',
+ 'id. Talk to ben@ or jam@ for more information.',
+ ),
+ True,
+ ),
)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698