Add a presubmit check to stop any more usages of harmful browser::Find* methods while we work throu…

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 96 matching lines @@
 )
 
 
 _BANNED_CPP_FUNCTIONS = (
     # Make sure that gtest's FRIEND_TEST() macro is not used; the
     # FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be
     # used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes.
     (
       'FRIEND_TEST(',
       (
-       'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include'
+       'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include',
        'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.',
       ),
       False,
     ),
     (
       'ScopedAllowIO',
       (
-       'New code should not use ScopedAllowIO. Post a task to the blocking pool'
-       'or the FILE thread instead.',
+       'New code should not use ScopedAllowIO. Post a task to the blocking',
+       'pool or the FILE thread instead.',
+      ),
+      True,
+    ),
+    (
+      'FilePathWatcher::Delegate',
+      (
+       'New code should not use FilePathWatcher::Delegate. Use the callback',
+       'interface instead.',
       ),
       False,
     ),
     (
-      'FilePathWatcher::Delegate',
+      'browser::FindLastActiveWithProfile',
       (
-       'New code should not use FilePathWatcher::Delegate. Use the callback'
-       'interface instead.',
+       'This function is deprecated and we\'re working on removing it. Pass',
+       'more context to get a Browser*, like a WebContents, window, or session',
+       'id. Talk to ben@ or jam@ for more information.',
       ),
-      False,
+      True,
+    ),
+    (
+      'browser::FindBrowserWithProfile',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass',
+       'more context to get a Browser*, like a WebContents, window, or session',
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindAnyBrowser',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass',
+       'more context to get a Browser*, like a WebContents, window, or session',
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindOrCreateTabbedBrowser',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass',
+       'more context to get a Browser*, like a WebContents, window, or session',
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindTabbedBrowser',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass',
+       'more context to get a Browser*, like a WebContents, window, or session',
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
     ),
 )
 
 
 
 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
   """Attempts to prevent use of functions intended only for testing in
   non-testing code. For now this is just a best-effort implementation
   that ignores header files and may have some false positives. A
   better implementation would probably need a proper C++ parser.
@@ skipping 309 matching lines @@
   for non_android_re in (aura_re, win_re):
     if all(re.search(non_android_re, f) for f in affected_files):
       possibly_android = False
       break
   if possibly_android:
     for f in change.AffectedFiles():
       if any(re.search(r, f.LocalPath()) for r in android_re_list):
         preferred.append('android')
         break
   return preferred