Issue 10626020: Merge 120850 - Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10626020: Merge 120850 - Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high … (Closed)

Created:
8 years, 6 months ago by apavlov

Modified:
8 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Visibility:
Public.

More Reviews

Description

Merge 120850 - Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high CPU usage https://bugs.webkit.org/show_bug.cgi?id=89562 Reviewed by Ryosuke Niwa. Rather than replace the newlines in-place (in O(n^2)), build a new string using StringBuilder, which takes O(n). No new tests, this is a perf improvement. * platform/chromium/ClipboardUtilitiesChromium.cpp: (WebCore::replaceNewlinesWithWindowsStyleNewlines): * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::replaceNewlinesWithWindowsStyleNewlines): TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121035

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -24 lines)			Patch
	M	Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp	View		2 chunks	+8 lines, -12 lines	0 comments	Download
	M	Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp	View		2 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages