Merge 120850 - Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high …

Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp

 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
  * 
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  * 
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "config.h"
 #include "ClipboardUtilitiesChromium.h"
 
 #include "KURL.h"
 #include "Pasteboard.h"
 #include "PlatformString.h"
 
 #include <public/WebClipboard.h>
+#include <wtf/text/StringBuilder.h>
 
 namespace WebCore {
 
 WebKit::WebClipboard::Buffer currentPasteboardBuffer()
 {
     return Pasteboard::generalPasteboard()->isSelectionMode() ?
         WebKit::WebClipboard::BufferSelection :
         WebKit::WebClipboard::BufferStandard;
 }
 
 #if OS(WINDOWS)
 void replaceNewlinesWithWindowsStyleNewlines(String& str)
 {
     DEFINE_STATIC_LOCAL(String, windowsNewline, ("\r\n"));
-    const static unsigned windowsNewlineLength = windowsNewline.length();
-
-    unsigned index = 0;
-    unsigned strLength = str.length();
-    while (index < strLength) {
-        if (str[index] != '\n' || (index > 0 && str[index - 1] == '\r')) {
-            ++index;
-            continue;
-        }
-        str.replace(index, 1, windowsNewline);
-        strLength = str.length();
-        index += windowsNewlineLength;
+    StringBuilder result;
+    for (unsigned index = 0; index < str.length(); ++index) {
+        if (str[index] != '\n' || (index > 0 && str[index - 1] == '\r'))
+            result.append(str[index]);
+        else
+            result.append(windowsNewline);
     }
+    str = result.toString();
 }
 #endif
 
 void replaceNBSPWithSpace(String& str)
 {
     static const UChar NonBreakingSpaceCharacter = 0xA0;
     static const UChar SpaceCharacter = ' ';
     str.replace(NonBreakingSpaceCharacter, SpaceCharacter);
 }
 
@@ skipping 13 matching lines @@
         if (line[0] == '#')
             continue;
         KURL url = KURL(ParsedURLString, line);
         if (url.isValid())
             return url;
     }
     return String();
 }
 
 } // namespace WebCore