Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 10626020: Merge 120850 - Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high … (Closed)

Created:
8 years, 6 months ago by apavlov
Modified:
8 years, 6 months ago
Reviewers:
tony
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120850 - Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high CPU usage https://bugs.webkit.org/show_bug.cgi?id=89562 Reviewed by Ryosuke Niwa. Rather than replace the newlines in-place (in O(n^2)), build a new string using StringBuilder, which takes O(n). No new tests, this is a perf improvement. * platform/chromium/ClipboardUtilitiesChromium.cpp: (WebCore::replaceNewlinesWithWindowsStyleNewlines): * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::replaceNewlinesWithWindowsStyleNewlines): TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M Source/WebCore/platform/chromium/ClipboardUtilitiesChromium.cpp View 2 chunks +8 lines, -12 lines 0 comments Download
M Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp View 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
8 years, 6 months ago (2012-06-22 17:36:03 UTC) #1
tony
8 years, 6 months ago (2012-06-22 17:37:46 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698