| Index: chrome/browser/autocomplete/keyword_provider_unittest.cc
|
| diff --git a/chrome/browser/autocomplete/keyword_provider_unittest.cc b/chrome/browser/autocomplete/keyword_provider_unittest.cc
|
| index 685608d6a2d3bf99afa388df765a2b997485d2af..bb21e728af98a56aa55e84fc52c4ec00d29f44a5 100644
|
| --- a/chrome/browser/autocomplete/keyword_provider_unittest.cc
|
| +++ b/chrome/browser/autocomplete/keyword_provider_unittest.cc
|
| @@ -125,7 +125,17 @@ TEST_F(KeywordProviderTest, Edit) {
|
| &AutocompleteMatch::fill_into_edit);
|
| }
|
|
|
| -TEST_F(KeywordProviderTest, URL) {
|
| +// This test is incorrect. It suffers from the fact that comparing two
|
| +// non-identical invalid urls succeed (that is, GURL("invalid1") ==
|
| +// GURL("invalid2")) due to the fact that both in fact will be turned into empty
|
| +// URLs upon creation.
|
| +//
|
| +// For this test, this happens for the following comparisons:
|
| +//
|
| +// GURL("a+++b+++c%2B%2B=z") vs. GURL("a%20%20%20b%20%20%20c++=z")
|
| +// GURL("bogus%20URL%201+2+3") vs. GURL("bogus%20URL%201%202%203")
|
| +//
|
| +TEST_F(KeywordProviderTest, DISABLED_URL) {
|
| test_data<GURL> url_cases[] = {
|
| // No query input -> empty destination URL.
|
| {ASCIIToUTF16("z"), 1, {GURL()}},
|
|
|