Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_private_api.cc

Issue 10578017: Test GURL::spec() usage changes with DEPS rolled to the new version. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More fixes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
index e4ae2c83c004ba8caea7845594794a0f67e66a09..44f9f4ee5bdd9379cfc8fb109419b3278f3c3fc9 100644
--- a/chrome/browser/chromeos/extensions/file_browser_private_api.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
@@ -709,11 +709,14 @@ void FileBrowserFunction::GetLocalPathsOnFileThread(
// URLs. crosbug.com/27510.
//
// TODO(satorux): GURL::query() is not yet supported for filesystem:
- // URLs. For now, use GURL::spec() to get the query portion. Should
- // get rid of the hack once query() is supported: crbug.com/114484.
- const std::string::size_type query_start = file_url.spec().find('?');
+ // URLs. For now, use GURL::possibly_invalid_spec() to get the query
+ // portion. Should get rid of the hack once query() is supported:
+ // crbug.com/114484.
+ const std::string::size_type query_start =
+ file_url.possibly_invalid_spec().find('?');
if (query_start != std::string::npos) {
- const std::string query = file_url.spec().substr(query_start + 1);
+ const std::string query =
+ file_url.possibly_invalid_spec().substr(query_start + 1);
std::vector<std::pair<std::string, std::string> > parameters;
if (base::SplitStringIntoKeyValuePairs(
query, '=', '&', &parameters)) {
@@ -758,7 +761,7 @@ void FileBrowserFunction::GetLocalPathsOnFileThread(
display_name = virtual_path.BaseName().value();
} else {
LOG(WARNING) << "GetLocalPathsOnFileThread failed "
- << file_url.spec();
+ << file_url.possibly_invalid_spec();
}
if (!real_path.empty()) {
« no previous file with comments | « chrome/browser/autocomplete/keyword_provider_unittest.cc ('k') | chrome/browser/chromeos/proxy_config_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698