Test GURL::spec() usage changes with DEPS rolled to the new version.

chrome/browser/autocomplete/keyword_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/autocomplete/keyword_provider.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_service.h"
@@ skipping 107 matching lines @@
     {ASCIIToUTF16("ftp: blah"),       0, {}},
     {ASCIIToUTF16("mailto:z"),        0, {}},
     {ASCIIToUTF16("ftp://z"),         0, {}},
     {ASCIIToUTF16("https://z"),       1, {ASCIIToUTF16("z ")}},
   };
 
   RunTest<string16>(edit_cases, arraysize(edit_cases),
                     &AutocompleteMatch::fill_into_edit);
 }
 
-TEST_F(KeywordProviderTest, URL) {
+// This test is incorrect. It suffers from the fact that comparing two
+// non-identical invalid urls succeed (that is, GURL("invalid1") ==
+// GURL("invalid2")) due to the fact that both in fact will be turned into empty
+// URLs upon creation.
+//
+// For this test, this happens for the following comparisons:
+//
+// GURL("a+++b+++c%2B%2B=z") vs. GURL("a%20%20%20b%20%20%20c++=z")
+// GURL("bogus%20URL%201+2+3") vs. GURL("bogus%20URL%201%202%203")
+//
+TEST_F(KeywordProviderTest, DISABLED_URL) {
   test_data<GURL> url_cases[] = {
     // No query input -> empty destination URL.
     {ASCIIToUTF16("z"),               1, {GURL()}},
     {ASCIIToUTF16("z    \t"),         1, {GURL()}},
 
     // Check that tokenization only collapses whitespace between first tokens
     // and query input, but not rest of URL, is escaped.
     {ASCIIToUTF16("z   a   b   c++"), 1, {GURL("a+++b+++c%2B%2B=z")}},
     {ASCIIToUTF16("www.www www"),     1, {GURL(" +%2B?=wwwfoo ")}},
 
@@ skipping 79 matching lines @@
 
 TEST_F(KeywordProviderTest, GetKeywordForInput) {
   EXPECT_EQ(ASCIIToUTF16("aa"),
       kw_provider_->GetKeywordForText(ASCIIToUTF16("aa")));
   EXPECT_EQ(string16(),
       kw_provider_->GetKeywordForText(ASCIIToUTF16("aafoo")));
   EXPECT_EQ(string16(),
       kw_provider_->GetKeywordForText(ASCIIToUTF16("aa foo")));
 }