Fix most warnings and other minor cleanups.

lib/compiler/implementation/resolver.dart

Index: lib/compiler/implementation/resolver.dart
diff --git a/lib/compiler/implementation/resolver.dart b/lib/compiler/implementation/resolver.dart
index 8d449dbccaf7c811ebc117210342d57caf3d709f..3ab84c7dc809e0ce33018a5d292fe93d2917124b 100644
--- a/lib/compiler/implementation/resolver.dart
+++ b/lib/compiler/implementation/resolver.dart
@@ -50,24 +50,23 @@ class ResolverTask extends CompilerTask {
 
   TreeElements resolve(Element element) {
     return measure(() {
-      switch (element.kind) {
-        case ElementKind.GENERATIVE_CONSTRUCTOR:
-        case ElementKind.FUNCTION:
-        case ElementKind.GETTER:
-        case ElementKind.SETTER:
-          return resolveMethodElement(element);
-
-        case ElementKind.FIELD:
-          return resolveField(element);
-
-        case ElementKind.PARAMETER:
-        case ElementKind.FIELD_PARAMETER:
-          return resolveParameter(element);
-
-        default:
-          compiler.unimplemented(
-              "resolve($element)", node: element.parseNode(compiler));
+      ElementKind kind = element.kind;
+      if (kind === ElementKind.GENERATIVE_CONSTRUCTOR ||

[karlklose, 2012/06/15 12:43:46]

Break before ||?

+          kind === ElementKind.FUNCTION ||
+          kind === ElementKind.GETTER ||
+          kind === ElementKind.SETTER) {
+        return resolveMethodElement(element);
       }
+
+      if (kind === ElementKind.FIELD) return resolveField(element);
+
+      if (kind === ElementKind.PARAMETER ||
+          kind === ElementKind.FIELD_PARAMETER) {
+        return resolveParameter(element);
+      }
+
+      compiler.unimplemented("resolve($element)",
+                             node: element.parseNode(compiler));
     });
   }