Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: lib/compiler/implementation/operations.dart

Issue 10557003: Fix most warnings and other minor cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/operations.dart
diff --git a/lib/compiler/implementation/operations.dart b/lib/compiler/implementation/operations.dart
index e445678aa319176291d85c1692f5c8186a78a436..3bd11b8b52bcbd2d19d6b989e7d1d3cc50d5e3c7 100644
--- a/lib/compiler/implementation/operations.dart
+++ b/lib/compiler/implementation/operations.dart
@@ -235,8 +235,7 @@ class AddOperation implements BinaryOperation {
if (rightDartString.isEmpty()) {
return left;
} else if (leftString.value.isEmpty()) {
- // TODO(floitsch): There is no right.node. Find a node some other way.
- return new StringConstant(rightDartString, right.node);
+ return new StringConstant(rightDartString, leftString.node);
} else {
DartString concatenated =
new ConsDartString(leftString.value, rightDartString);

Powered by Google App Engine
This is Rietveld 408576698