Fix most warnings and other minor cleanups.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   Type getType(TypeAnnotation annotation);
 }
 
@@ skipping 32 matching lines @@
   Map<FunctionElement, TreeElements> constructorElements;
 
   ResolverTask(Compiler compiler)
     : super(compiler), toResolve = new Queue<ClassElement>(),
       constructorElements = new Map<FunctionElement, TreeElements>();
 
   String get name() => 'Resolver';
 
   TreeElements resolve(Element element) {
     return measure(() {
-      switch (element.kind) {
-        case ElementKind.GENERATIVE_CONSTRUCTOR:
-        case ElementKind.FUNCTION:
-        case ElementKind.GETTER:
-        case ElementKind.SETTER:
-          return resolveMethodElement(element);
+      ElementKind kind = element.kind;
+      if (kind === ElementKind.GENERATIVE_CONSTRUCTOR ||

[karlklose, 2012/06/15 12:43:46]

Break before ||?

+          kind === ElementKind.FUNCTION ||
+          kind === ElementKind.GETTER ||
+          kind === ElementKind.SETTER) {
+        return resolveMethodElement(element);
+      }
 
-        case ElementKind.FIELD:
-          return resolveField(element);
+      if (kind === ElementKind.FIELD) return resolveField(element);
 
-        case ElementKind.PARAMETER:
-        case ElementKind.FIELD_PARAMETER:
-          return resolveParameter(element);
+      if (kind === ElementKind.PARAMETER ||
+          kind === ElementKind.FIELD_PARAMETER) {
+        return resolveParameter(element);
+      }
 
-        default:
-          compiler.unimplemented(
-              "resolve($element)", node: element.parseNode(compiler));
-      }
+      compiler.unimplemented("resolve($element)",
+                             node: element.parseNode(compiler));
     });
   }
 
   SourceString getConstructorName(Send node) {
     if (node.receiver !== null) {
       return node.selector.asIdentifier().source;
     } else {
       return const SourceString('');
     }
   }
@@ skipping 2013 matching lines @@
 
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) {
     return library.find(name);
   }
 
   Element add(Element newElement) {
     throw "Cannot add an element in the top scope";
   }
 }