Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: lib/compiler/implementation/namer.dart

Issue 10557003: Fix most warnings and other minor cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/namer.dart
diff --git a/lib/compiler/implementation/namer.dart b/lib/compiler/implementation/namer.dart
index 123098ffbc349d3c877c63e3a84342e552c23b1a..09b1870464e19101b5d3d50c52ab01d2ca62fff9 100644
--- a/lib/compiler/implementation/namer.dart
+++ b/lib/compiler/implementation/namer.dart
@@ -94,15 +94,15 @@ class Namer {
String setterName(LibraryElement lib, SourceString name) {
// We dynamically create setters from the field-name. The setter name must
// therefore be derived from the instance field-name.
- String safeName = safeName(privateName(lib, name));
- return 'set\$$safeName';
+ String fieldName = safeName(privateName(lib, name));
+ return 'set\$$fieldName';
}
String getterName(LibraryElement lib, SourceString name) {
// We dynamically create getters from the field-name. The getter name must
// therefore be derived from the instance field-name.
- String safeName = safeName(privateName(lib, name));
- return 'get\$$safeName';
+ String fieldName = safeName(privateName(lib, name));
+ return 'get\$$fieldName';
}
String getFreshGlobalName(String proposedName) {
@@ -196,28 +196,26 @@ class Namer {
if (cached !== null) return cached;
String guess = _computeGuess(element);
- switch (element.kind) {
- case ElementKind.VARIABLE:
- case ElementKind.PARAMETER:
- // The name is not guaranteed to be unique.
- return guess;
-
- case ElementKind.GENERATIVE_CONSTRUCTOR:
- case ElementKind.FUNCTION:
- case ElementKind.CLASS:
- case ElementKind.FIELD:
- case ElementKind.GETTER:
- case ElementKind.SETTER:
- case ElementKind.TYPEDEF:
- case ElementKind.LIBRARY:
- String result = getFreshGlobalName(guess);
- globals[element] = result;
- return result;
-
- default:
- compiler.internalError('getName for unknown kind: ${element.kind}',
- node: element.parseNode(compiler));
+ ElementKind kind = element.kind;
+ if (kind === ElementKind.VARIABLE ||
+ kind === ElementKind.PARAMETER) {
+ // The name is not guaranteed to be unique.
+ return guess;
}
+ if (kind === ElementKind.GENERATIVE_CONSTRUCTOR ||
+ kind === ElementKind.FUNCTION ||
+ kind === ElementKind.CLASS ||
+ kind === ElementKind.FIELD ||
+ kind === ElementKind.GETTER ||
+ kind === ElementKind.SETTER ||
+ kind === ElementKind.TYPEDEF ||
+ kind === ElementKind.LIBRARY) {
+ String result = getFreshGlobalName(guess);
+ globals[element] = result;
+ return result;
+ }
+ compiler.internalError('getName for unknown kind: ${element.kind}',
+ node: element.parseNode(compiler));
}
}

Powered by Google App Engine
This is Rietveld 408576698