Fix most warnings and other minor cleanups.

lib/compiler/implementation/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer {
   final Compiler compiler;
 
@@ skipping 76 matching lines @@
       String libName = getName(cls.getLibrary());
       String clsName = getName(cls);
       proposedName = '$libName\$$clsName\$$proposedName';
     }
     return safeName(proposedName);
   }
 
   String setterName(LibraryElement lib, SourceString name) {
     // We dynamically create setters from the field-name. The setter name must
     // therefore be derived from the instance field-name.
-    String safeName = safeName(privateName(lib, name));
-    return 'set\$$safeName';
+    String fieldName = safeName(privateName(lib, name));
+    return 'set\$$fieldName';
   }
 
   String getterName(LibraryElement lib, SourceString name) {
     // We dynamically create getters from the field-name. The getter name must
     // therefore be derived from the instance field-name.
-    String safeName = safeName(privateName(lib, name));
-    return 'get\$$safeName';
+    String fieldName = safeName(privateName(lib, name));
+    return 'get\$$fieldName';
   }
 
   String getFreshGlobalName(String proposedName) {
     int usedCount = usedGlobals[proposedName];
     if (usedCount === null) {
       // No element with this name has been used before.
       usedGlobals[proposedName] = 1;
       return proposedName;
     } else {
       // Not the first time we see this name. Append a number to make it unique.
@@ skipping 73 matching lines @@
         return setterName(element.getLibrary(), element.name);
       } else {
         return instanceFieldName(element.getEnclosingClass(), element.name);
       }
     } else {
       // Dealing with a top-level or static element.
       String cached = globals[element];
       if (cached !== null) return cached;
 
       String guess = _computeGuess(element);
-      switch (element.kind) {
-        case ElementKind.VARIABLE:
-        case ElementKind.PARAMETER:
-          // The name is not guaranteed to be unique.
-          return guess;
-
-        case ElementKind.GENERATIVE_CONSTRUCTOR:
-        case ElementKind.FUNCTION:
-        case ElementKind.CLASS:
-        case ElementKind.FIELD:
-        case ElementKind.GETTER:
-        case ElementKind.SETTER:
-        case ElementKind.TYPEDEF:
-        case ElementKind.LIBRARY:
-          String result = getFreshGlobalName(guess);
-          globals[element] = result;
-          return result;
-
-        default:
-          compiler.internalError('getName for unknown kind: ${element.kind}',
-                                 node: element.parseNode(compiler));
+      ElementKind kind = element.kind;
+      if (kind === ElementKind.VARIABLE ||
+          kind === ElementKind.PARAMETER) {
+        // The name is not guaranteed to be unique.
+        return guess;
       }
+      if (kind === ElementKind.GENERATIVE_CONSTRUCTOR ||
+          kind === ElementKind.FUNCTION ||
+          kind === ElementKind.CLASS ||
+          kind === ElementKind.FIELD ||
+          kind === ElementKind.GETTER ||
+          kind === ElementKind.SETTER ||
+          kind === ElementKind.TYPEDEF ||
+          kind === ElementKind.LIBRARY) {
+        String result = getFreshGlobalName(guess);
+        globals[element] = result;
+        return result;
+      }
+      compiler.internalError('getName for unknown kind: ${element.kind}',
+                              node: element.parseNode(compiler));
     }
   }
 
   String isolatePropertiesAccess(Element element) {
     return "$ISOLATE.$ISOLATE_PROPERTIES.${getName(element)}";
   }
 
   String isolatePropertiesAccessForConstant(String constantName) {
     return "$ISOLATE.$ISOLATE_PROPERTIES.$constantName";
   }
@@ skipping 11 matching lines @@
   }
 
   String safeName(String name) {
     if (jsReserved.contains(name) || name.startsWith('\$')) {
       name = "\$$name";
       assert(!jsReserved.contains(name));
     }
     return name;
   }
 }