Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 10556042: Update GTest Parsing Code (Closed)

Created:
8 years, 6 months ago by csharp
Modified:
8 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Update GTest parsing code to allow show timed out tests as failures (even if they are prefixed FAILS_) BUG=128978 TEST=Tests that are marked as FAILS_ but timeout should now be listed as reason for step failure. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142713

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M scripts/common/gtest_utils.py View 1 chunk +5 lines, -3 lines 0 comments Download
M scripts/common/unittests/gtest_utils_test.py View 1 2 5 chunks +19 lines, -8 lines 0 comments Download
M scripts/master/log_parser/gtest_command.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
csharp
Fix the issue of the timeout failure getting ignore. I'm now going to look into ...
8 years, 6 months ago (2012-06-18 14:51:35 UTC) #1
M-A Ruel
lgtm with nit https://chromiumcodereview.appspot.com/10556042/diff/1/scripts/common/unittests/gtest_utils_test.py File scripts/common/unittests/gtest_utils_test.py (right): https://chromiumcodereview.appspot.com/10556042/diff/1/scripts/common/unittests/gtest_utils_test.py#newcode20 scripts/common/unittests/gtest_utils_test.py:20: 'SomeOtherTest.FAILS_FooBar'] maybe renaming it to SomeOtherTest.FAILS_ThisTestTimesOut ...
8 years, 6 months ago (2012-06-18 14:55:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10556042/5001
8 years, 6 months ago (2012-06-18 15:17:33 UTC) #3
csharp
https://chromiumcodereview.appspot.com/10556042/diff/1/scripts/common/unittests/gtest_utils_test.py File scripts/common/unittests/gtest_utils_test.py (right): https://chromiumcodereview.appspot.com/10556042/diff/1/scripts/common/unittests/gtest_utils_test.py#newcode20 scripts/common/unittests/gtest_utils_test.py:20: 'SomeOtherTest.FAILS_FooBar'] On 2012/06/18 14:55:57, Marc-Antoine Ruel wrote: > maybe ...
8 years, 6 months ago (2012-06-18 15:17:39 UTC) #4
commit-bot: I haz the power
Presubmit check for 10556042-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-18 15:19:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10556042/8001
8 years, 6 months ago (2012-06-18 15:32:23 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-18 15:34:29 UTC) #7
Change committed as 142713

Powered by Google App Engine
This is Rietveld 408576698