Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: scripts/common/gtest_utils.py

Issue 10556042: Update GTest Parsing Code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/common/unittests/gtest_utils_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/common/gtest_utils.py
diff --git a/scripts/common/gtest_utils.py b/scripts/common/gtest_utils.py
index 52dac09aa15905ec9ec1faf21486271ed9d7f1fc..b1128bbf217a788da6ce722171ca575e737f5f68 100755
--- a/scripts/common/gtest_utils.py
+++ b/scripts/common/gtest_utils.py
@@ -115,13 +115,15 @@ class GTestLogParser(object):
Args:
include_fails: If true, all failing tests with FAILS_ in their names will
- be included. Otherwise, they will only be included if they crashed.
+ be included. Otherwise, they will only be included if they crashed or
+ timed out.
include_flaky: If true, all failing tests with FLAKY_ in their names will
- be included. Otherwise, they will only be included if they crashed.
+ be included. Otherwise, they will only be included if they crashed or
+ timed out.
"""
return (self._TestsByStatus('failed', include_fails, include_flaky) +
- self._TestsByStatus('timeout', include_fails, include_flaky) +
+ self._TestsByStatus('timeout', True, True) +
self._TestsByStatus('warning', include_fails, include_flaky) +
self.RunningTests())
« no previous file with comments | « no previous file | scripts/common/unittests/gtest_utils_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698