Add decoration to the language button to indicate that a third party IME is in use

Add decoration to the language button to indicate that a third party IME is in use


TBR=jhawkins@chromium.org
BUG=None
TEST=Install an IME extension.  Enable it.  Check that the Language Bar indicates that it is 3rd party

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141594

[Zachary Kuznia, 2012-06-08 08:20:51]

Hi yusukes, sadrul,

Could you review this at:
https://chromiumcodereview.appspot.com/10544070

Thanks,
-Zach

[Yusuke Sato, 2012-06-08 08:25:50]

input_method/ LGTM

On 2012/06/08 08:20:51, Zachary Kuznia wrote:
> Hi yusukes, sadrul,
> 
> Could you review this at:
> https://chromiumcodereview.appspot.com/10544070
> 
> Thanks,
> -Zach

[Yusuke Sato, 2012-06-08 08:26:02]

http://codereview.chromium.org/10544070/diff/1/chrome/browser/chromeos/input_...
File chrome/browser/chromeos/input_method/input_method_descriptor.h (right):

http://codereview.chromium.org/10544070/diff/1/chrome/browser/chromeos/input_...
chrome/browser/chromeos/input_method/input_method_descriptor.h:40: const bool
third_party() const { return third_party_; }
nit: const bool -> bool

[sadrul, 2012-06-08 11:29:41]

ash/system LGTM

[sadrul, 2012-06-08 11:31:04]

On 2012/06/08 11:29:41, sadrul wrote:
> ash/system LGTM

chromeos/system LGTM too

[Zachary Kuznia, 2012-06-11 06:28:21]

http://codereview.chromium.org/10544070/diff/1/chrome/browser/chromeos/input_...
File chrome/browser/chromeos/input_method/input_method_descriptor.h (right):

http://codereview.chromium.org/10544070/diff/1/chrome/browser/chromeos/input_...
chrome/browser/chromeos/input_method/input_method_descriptor.h:40: const bool
third_party() const { return third_party_; }
On 2012/06/08 08:26:02, Yusuke Sato wrote:
> nit: const bool -> bool

Done.

[commit-bot: I haz the power, 2012-06-11 06:28:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/10544070/7001

[commit-bot: I haz the power, 2012-06-11 07:02:45]

Try job failure for 10544070-7001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-06-11 09:10:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/10544070/1011

[commit-bot: I haz the power, 2012-06-11 09:10:21]

Presubmit check for 10544070-1011 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui/options2

Presubmit checks took 1.3s to calculate.

[commit-bot: I haz the power, 2012-06-11 09:25:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/10544070/1011

[commit-bot: I haz the power, 2012-06-11 11:17:20]

Try job failure for 10544070-1011 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-06-11 23:33:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/10544070/1011

[commit-bot: I haz the power, 2012-06-12 01:58:17]

Change committed as 141594