Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: chrome/browser/chromeos/input_method/input_method_descriptor.cc

Issue 10544070: Add decoration to the language button to indicate that a third party IME is in use (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit tests Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_descriptor.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_descriptor.cc b/chrome/browser/chromeos/input_method/input_method_descriptor.cc
index a0e03d458058e7a9b4e7a658dec3f4df189f26ea..5e68ed3209a70aaf1a6bccff9530ab8533ffb4c2 100644
--- a/chrome/browser/chromeos/input_method/input_method_descriptor.cc
+++ b/chrome/browser/chromeos/input_method/input_method_descriptor.cc
@@ -19,14 +19,16 @@ const char kFallbackLayout[] = "us";
InputMethodDescriptor::InputMethodDescriptor(const std::string& id,
const std::string& name,
const std::string& keyboard_layout,
- const std::string& language_code)
+ const std::string& language_code,
+ bool third_party)
: id_(id),
name_(name),
keyboard_layout_(keyboard_layout),
- language_code_(language_code) {
+ language_code_(language_code),
+ third_party_(third_party) {
}
-InputMethodDescriptor::InputMethodDescriptor() {
+InputMethodDescriptor::InputMethodDescriptor() : third_party_(false) {
}
InputMethodDescriptor::~InputMethodDescriptor() {
@@ -48,7 +50,8 @@ InputMethodDescriptor::GetFallbackInputMethodDescriptor() {
return InputMethodDescriptor("xkb:us::eng",
"",
kFallbackLayout,
- "en-US");
+ "en-US",
+ false);
}
std::string InputMethodDescriptor::ToString() const {
@@ -56,7 +59,8 @@ std::string InputMethodDescriptor::ToString() const {
stream << "id=" << id()
<< ", name=" << name()
<< ", keyboard_layout=" << keyboard_layout()
- << ", language_code=" << language_code();
+ << ", language_code=" << language_code()
+ << ", third_party=" << third_party();
return stream.str();
}

Powered by Google App Engine
This is Rietveld 408576698