Issue 10544009: ash/app_list: Make applist bubble edge touch launcher bar edge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544009: ash/app_list: Make applist bubble edge touch launcher bar edge. (Closed)

Created:
8 years, 6 months ago by xiyuan

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash/app_list: Make applist bubble edge touch launcher bar edge. - Shift down (or left/right for launcher side doc) kArrowHeight pixels so that the bubble edge lands on launcher bar edge. - Make v2 applist container on top of launcher bar so that the arrow shows on top of launcher bar; BUG=131126 TEST=Verify app list bubble edge is attached to launcher bar edge and it arrow is on top of the launcher bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140660

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
	M	ash/shell.cc	View		1 chunk	+14 lines, -3 lines	0 comments	Download
	M	ui/app_list/app_list_bubble_border.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10544009/1

8 years, 6 months ago (2012-06-05 22:49:25 UTC) #3

Change committed as 140660

Expand Messages | Collapse Messages