Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 10544009: ash/app_list: Make applist bubble edge touch launcher bar edge. (Closed)

Created:
8 years, 6 months ago by xiyuan
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash/app_list: Make applist bubble edge touch launcher bar edge. - Shift down (or left/right for launcher side doc) kArrowHeight pixels so that the bubble edge lands on launcher bar edge. - Make v2 applist container on top of launcher bar so that the arrow shows on top of launcher bar; BUG=131126 TEST=Verify app list bubble edge is attached to launcher bar edge and it arrow is on top of the launcher bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M ash/shell.cc View 1 chunk +14 lines, -3 lines 0 comments Download
M ui/app_list/app_list_bubble_border.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
8 years, 6 months ago (2012-06-05 17:41:31 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-05 19:55:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10544009/1
8 years, 6 months ago (2012-06-05 22:49:25 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-06 00:09:04 UTC) #4
Change committed as 140660

Powered by Google App Engine
This is Rietveld 408576698