Changed device_orientation_dispatcher to use default constructor in WebDeviceOrientation.h. This de…

Changed device_orientation_dispatcher to use default constructor in WebDeviceOrientation.h.

This depends on WebKit patch at https://bugs.webkit.org/show_bug.cgi?id=88406.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141193

[hans, 2012-06-06 14:41:26]

On 2012/06/06 13:29:46, aousterh wrote:

I'd put two line breaks in the description (between "in WebDeviceOrientation.h."
and "This depends on ...")

LGTM

[hans, 2012-06-06 14:41:59]

jamesr: content/renderer/OWNERS approval?

[jamesr, 2012-06-06 23:09:04]

https://chromiumcodereview.appspot.com/10542025/diff/1/content/renderer/devic...
File content/renderer/device_orientation_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10542025/diff/1/content/renderer/devic...
content/renderer/device_orientation_dispatcher.cc:86:
WebKit::WebDeviceOrientation *orientation =
why is the allocated on the heap? it looks like this is just a simple struct
with data members that could be easily stack allocated / copied as needed

[aousterh, 2012-06-07 11:06:00]

Good point. I changed last_orientation_ so that it is now a
WebKit::WebDeviceOrientation rather than a
scoped_ptr<WebKit::WebDeviceOrientation>.

[jamesr, 2012-06-07 20:39:38]

lgtm

[commit-bot: I haz the power, 2012-06-08 08:53:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aousterh@chromium.org/10542025/6001

[commit-bot: I haz the power, 2012-06-08 10:38:19]

Change committed as 141193