Changed device_orientation_dispatcher to use default constructor in WebDeviceOrientation.h. This de…

content/renderer/device_orientation_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/device_orientation_dispatcher.h"
 
 #include "content/common/device_orientation_messages.h"
 #include "content/renderer/render_view_impl.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDeviceOrientation.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDeviceOrientationController.h"
@@ skipping 65 matching lines @@
 
   return true;
 }
 }  // namespace
 
 void DeviceOrientationDispatcher::OnDeviceOrientationUpdated(
     const DeviceOrientationMsg_Updated_Params& p) {
   if (last_orientation_.get() && OrientationsEqual(p, last_orientation_.get()))
     return;
 
-  last_orientation_.reset(new WebKit::WebDeviceOrientation(p.can_provide_alpha,
-                                                       p.alpha,
-                                                       p.can_provide_beta,
-                                                       p.beta,
-                                                       p.can_provide_gamma,
-                                                       p.gamma,
-                                                       p.can_provide_absolute,
-                                                       p.absolute));
-
+  WebKit::WebDeviceOrientation *orientation =

[jamesr, 2012/06/06 23:09:05]

why is the allocated on the heap? it looks like this is just a simple struct
with data members that could be easily stack allocated / copied as needed

+    new WebKit::WebDeviceOrientation();
+  orientation->setNull(false);
+  if (p.can_provide_alpha)
+    orientation->setAlpha(p.alpha);
+  if (p.can_provide_beta)
+    orientation->setBeta(p.beta);
+  if (p.can_provide_gamma)
+    orientation->setGamma(p.gamma);
+  if (p.can_provide_absolute)
+    orientation->setAbsolute(p.absolute);
+  last_orientation_.reset(orientation);
   controller_->didChangeDeviceOrientation(*last_orientation_);
 }