Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10540123: Rename gfx::Screen::GetMonitorXXXX to gfx::Screen::GetDisplayXXX. (Closed)

Created:
8 years, 6 months ago by tfarina
Modified:
8 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, MAD, sadrul, yusukes+watch_chromium.org, dcheng, alicet1, Ilya Sherman, nkostylev+watch_chromium.org, msw+watch_chromium.org, jar (doing other things), ben+watch_chromium.org, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, derat+watch_chromium.org, jennb, jochen+watch-content_chromium.org, penghuang+watch_chromium.org, jianli, feature-media-reviews_chromium.org, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, tfarina, Dmitry Titov, Aaron Boodman, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename gfx::Screen::GetMonitorXXXX to gfx::Screen::GetDisplayXXX. BUG=130828 R=oshima@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142631

Patch Set 1 : #

Patch Set 2 : fixes and rebases #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -279 lines) Patch
M ash/dip_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/monitor/monitor_controller.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/monitor/multi_monitor_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/monitor/multi_monitor_manager.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M ash/monitor/multi_monitor_manager_unittest.cc View 1 6 chunks +22 lines, -22 lines 0 comments Download
M ash/screen_ash.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/screen_ash.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M ash/screensaver/screensaver_view.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_filter_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/window_animations.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_resizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/maximized_workspace.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/snap_sizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/display_settings_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/window_positioner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/window_positioner_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/dock_info_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/window_sizer_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer_common_unittest.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/window_sizer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/dip_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/desktop/desktop_screen_win.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/desktop/desktop_screen_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/desktop/desktop_screen_x11.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M ui/aura/monitor_manager.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/monitor_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/single_monitor_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/single_monitor_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/test/test_screen.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/events_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen.h View 3 chunks +13 lines, -11 lines 0 comments Download
M ui/gfx/screen_android.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M ui/gfx/screen_aura.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/gfx/screen_gtk.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/screen_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/screen_mac.mm View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/screen_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/screen_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
8 years, 6 months ago (2012-06-12 19:49:01 UTC) #1
oshima
LGTM Please run trybots on all platforms including android.
8 years, 6 months ago (2012-06-12 21:33:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10540123/91
8 years, 6 months ago (2012-06-13 22:46:00 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 22:46:28 UTC) #4 
Failed to apply patch for chrome/browser/ui/tabs/dock_info_win.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/tabs/dock_info_win.cc
Hunk #1 FAILED at 242.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/tabs/dock_info_win.cc.rej

Powered by Google App Engine
This is Rietveld 408576698