Make isUtc a getter, change some method names in Date.

Make isUtc a getter, change some method names in Date. Weekday is now 1 based.

isUtc is now a getter.
Date.hours -> Date.hour
Date.minutes -> Date.minute
Date.seconds -> Date.second
Date.milliseconds -> Date.millisecond
Date.fromEpoch -> Date.fromMillisecondsSinceEpoch
Date.value -> Date.millisecondsSinceEpoch
Date.MON == 1 (up to Date.SUN == 7).

Fixes issue 3444, 1985.

Committed: https://code.google.com/p/dart/source/detail?r=8899

[floitsch, 2012-06-15 14:27:11]

Once I get an LGTM I will announce the breaking change on the mailing list.

[Lasse Reichstein Nielsen, 2012-06-19 14:32:18]

LGTM (I trust the changes that are merely renames are correct)

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.dart
File corelib/src/date.dart (left):

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:46: [int month,
Is "month" zero or one-based?
Are overflowing values allowed? (e.g, month 13 being January of the next year)

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:47: int day,
Should month and day really be optional? It makes little sense to me to create a
Date without specifying an actual date. 
At least give them default values of 1 and 1 when possible.
(Personally, I think you should drop the split between Date and
DateImplementation, and just include the implementation here - there won't be
any other (non-test) implementation of Date anyway).

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.dart
File corelib/src/date.dart (right):

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:24: static final int SUN = 7;
Are there definitions for JAN...DEC? Preferably one-based?

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:156: * Returns the hour in the day [0..23].
"in" -> "into". There are always 24 hours in the day :)

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:161: * Returns the minute in the hour [0...59].
"in" -> "into" again.

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:166: * Returns the second in the minute [0...59].
And again.
We are absolutely certain we won't need leap seconds?

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:171: * Returns the millisecond in the second [0...999].
And again.

[floitsch, 2012-06-20 08:25:24]

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.dart
File corelib/src/date.dart (left):

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:46: [int month,
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> Is "month" zero or one-based?
1-based (added comment).

> Are overflowing values allowed? (e.g, month 13 being January of the next year)
not yet, but I intend to allow it:
http://dartbug/2771

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:47: int day,
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> Should month and day really be optional? It makes little sense to me to create
a
> Date without specifying an actual date. 
See http://dartbug/2582.
Apparently requiring month and day is less useful.

> At least give them default values of 1 and 1 when possible.
They all default to the smallest valid value. (which would be 1 and 1).
> (Personally, I think you should drop the split between Date and
> DateImplementation, and just include the implementation here - there won't be
> any other (non-test) implementation of Date anyway).
Another CL.

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.dart
File corelib/src/date.dart (right):

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:24: static final int SUN = 7;
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> Are there definitions for JAN...DEC? Preferably one-based?

one line below?

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:156: * Returns the hour in the day [0..23].
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> "in" -> "into". There are always 24 hours in the day :)

Done.

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:161: * Returns the minute in the hour [0...59].
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> "in" -> "into" again.

Done.

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:166: * Returns the second in the minute [0...59].
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> And again.
> We are absolutely certain we won't need leap seconds?
I think so.
If leap-seconds are an issue some systems (for example Android) apparently use a
special timezone that takes leap-seconds into account.

https://chromiumcodereview.appspot.com/10538105/diff/4001/corelib/src/date.da...
corelib/src/date.dart:171: * Returns the millisecond in the second [0...999].
On 2012/06/19 14:32:18, Lasse Reichstein Nielsen wrote:
> And again.

Done.