Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 10538105: Make isUtc a getter, change some method names in Date. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/lib/js_helper.dart
diff --git a/lib/compiler/implementation/lib/js_helper.dart b/lib/compiler/implementation/lib/js_helper.dart
index a5cb94f47ff5942f94820fd7f4ae4fd50ab75731..807a519e21315da5ee6745c54f4525b4fb338beb 100644
--- a/lib/compiler/implementation/lib/js_helper.dart
+++ b/lib/compiler/implementation/lib/js_helper.dart
@@ -517,55 +517,56 @@ class Primitives {
// Lazily keep a JS Date stored in the JS object.
static lazyAsJsDate(receiver) {
if (JS('bool', @'#.date === (void 0)', receiver)) {
- JS('void', @'#.date = new Date(#)', receiver, receiver.value);
+ JS('void', @'#.date = new Date(#)', receiver,
+ receiver.millisecondsSinceEpoch);
}
return JS('Date', @'#.date', receiver);
}
static getYear(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCFullYear()', lazyAsJsDate(receiver))
: JS('int', @'#.getFullYear()', lazyAsJsDate(receiver));
}
static getMonth(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCMonth()', lazyAsJsDate(receiver)) + 1
: JS('int', @'#.getMonth()', lazyAsJsDate(receiver)) + 1;
}
static getDay(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCDate()', lazyAsJsDate(receiver))
: JS('int', @'#.getDate()', lazyAsJsDate(receiver));
}
static getHours(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCHours()', lazyAsJsDate(receiver))
: JS('int', @'#.getHours()', lazyAsJsDate(receiver));
}
static getMinutes(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCMinutes()', lazyAsJsDate(receiver))
: JS('int', @'#.getMinutes()', lazyAsJsDate(receiver));
}
static getSeconds(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCSeconds()', lazyAsJsDate(receiver))
: JS('int', @'#.getSeconds()', lazyAsJsDate(receiver));
}
static getMilliseconds(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCMilliseconds()', lazyAsJsDate(receiver))
: JS('int', @'#.getMilliseconds()', lazyAsJsDate(receiver));
}
static getWeekday(receiver) {
- return (receiver.isUtc())
+ return (receiver.isUtc)
? JS('int', @'#.getUTCDay()', lazyAsJsDate(receiver))
: JS('int', @'#.getDay()', lazyAsJsDate(receiver));
}

Powered by Google App Engine
This is Rietveld 408576698