Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: dart/lib/compiler/implementation/enqueue.dart

Issue 10537129: Address review comments from https://chromiumcodereview.appspot.com/10542073/ (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/compiler.dart ('k') | dart/lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/enqueue.dart
diff --git a/dart/lib/compiler/implementation/enqueue.dart b/dart/lib/compiler/implementation/enqueue.dart
index a0a453af6be5b08e14bf3beae2e3f81602e759f5..0d8b1e7bc66ffa7f267755a87b71a7d3a319fb16 100644
--- a/dart/lib/compiler/implementation/enqueue.dart
+++ b/dart/lib/compiler/implementation/enqueue.dart
@@ -34,7 +34,7 @@ class Enqueuer {
queue = new Queue<WorkItem>(),
resolvedElements = new Map<Element, TreeElements>();
- bool get isFirstQueue() => compiler.enqueuer.resolution === this;
+ bool get isResolutionQueue() => compiler.enqueuer.resolution === this;
TreeElements getCachedElements(Element element) {
Element owner = element.getOutermostEnclosingMemberOrTopLevel();
@@ -44,10 +44,11 @@ class Enqueuer {
void addToWorkList(Element element, [TreeElements elements]) {
if (element.isForeign()) return;
if (queueIsClosed) {
- if (isFirstQueue && getCachedElements(element) !== null) return;
+ if (isResolutionQueue && getCachedElements(element) !== null) return;
compiler.internalErrorOnElement(element, "Work list is closed.");
}
- if (!isFirstQueue && element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
+ if (!isResolutionQueue &&
+ element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
registerInstantiatedClass(element.enclosingElement);
}
if (elements === null) {
« no previous file with comments | « dart/lib/compiler/implementation/compiler.dart ('k') | dart/lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698