Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: dart/lib/compiler/implementation/compiler.dart

Issue 10537129: Address review comments from https://chromiumcodereview.appspot.com/10542073/ (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/lib/compiler/implementation/enqueue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/compiler.dart
diff --git a/dart/lib/compiler/implementation/compiler.dart b/dart/lib/compiler/implementation/compiler.dart
index b3f16992d4ebd9665157b472f113375c047ec38c..581e96d27e9e590a1a65ed49a7a0e3230485e1c8 100644
--- a/dart/lib/compiler/implementation/compiler.dart
+++ b/dart/lib/compiler/implementation/compiler.dart
@@ -432,7 +432,7 @@ class Compiler implements DiagnosticListener {
/**
* Perform various checks of the queues. This includes checking that
* the queues are empty (nothing was added after we stopped
- * processing the quese). Also compute the number of methods that
+ * processing the queues). Also compute the number of methods that
* were resolved, but not compiled (aka excess resolution).
*/
checkQueues() {
@@ -478,12 +478,12 @@ class Compiler implements DiagnosticListener {
TreeElements analyzeElement(Element element) {
TreeElements elements = enqueuer.resolution.getCachedElements(element);
if (elements !== null) return elements;
- if (element is AbstractFieldElement) {
- return null;
- }
final int allowed = ElementCategory.VARIABLE | ElementCategory.FUNCTION
| ElementCategory.FACTORY;
- if (!element.isAccessor() && (element.kind.category & allowed) == 0) {
+ ElementKind kind = element.kind;
+ if (!element.isAccessor() &&
+ ((kind === ElementKind.ABSTRACT_FIELD) ||
+ (kind.category & allowed) == 0)) {
return null;
}
assert(parser !== null);
« no previous file with comments | « no previous file | dart/lib/compiler/implementation/enqueue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698