Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: dart/lib/compiler/implementation/resolver.dart

Issue 10537129: Address review comments from https://chromiumcodereview.appspot.com/10542073/ (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/enqueue.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/resolver.dart
diff --git a/dart/lib/compiler/implementation/resolver.dart b/dart/lib/compiler/implementation/resolver.dart
index 8be9f01a927b4f85c8e7f78c38fd1386e9aada03..245583fdbbdbbb430eec78c887da84f5dc4752f6 100644
--- a/dart/lib/compiler/implementation/resolver.dart
+++ b/dart/lib/compiler/implementation/resolver.dart
@@ -1087,7 +1087,7 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
// TODO(ngeoffray): Warn if target is null and the send is
// unqualified.
useElement(node, target);
- if (target === null) handleDynamicSend(node);
+ if (target === null) registerDynamicSend(node);
if (node.isPropertyAccess) return target;
}
@@ -1123,11 +1123,11 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
mapping.setSelector(node, selector);
// TODO(ngeoffray): Warn if target is null and the send is
// unqualified.
- handleDynamicSend(node);
+ registerDynamicSend(node);
return useElement(node, setter);
}
- handleDynamicSend(Send node) {
+ registerDynamicSend(Send node) {
Identifier id = node.selector.asIdentifier();
if (id === null) return;
SourceString name = node.selector.asIdentifier().source;
« no previous file with comments | « dart/lib/compiler/implementation/enqueue.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698