Switch back to the old method of launching the login flow while keeping some of the benefits of the…

Switch back to the old method of launching the login flow while keeping some of the benefits of the new method.

BUG=chromium-os:31470
TEST=functional/chromeos_login.py

Change-Id: I31555baedabb76f049b568479d7db42eebf105cc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141247

[Nirnimesh, 2012-06-07 00:30:55]

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider_chromeos.cc (right):

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider_chromeos.cc:284:
LOG(ERROR) << "TestingAutomationProvider::Login";
Login->StartLogin

Why LOG(ERROR)?

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider_chromeos.cc:303:
LOG(ERROR) << "TestingAutomationProvider::Login ShowSigninScreenForCreds("
Use VLOG(2)

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:88: from pyauto_errors import LoginError
remove?

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:4121: will not be noticed here, because the
browser has no knowledge of it.
Add: All such scenarios will lead to timeout of the Login() call

[craigdh, 2012-06-07 19:12:01]

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider_chromeos.cc (right):

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider_chromeos.cc:284:
LOG(ERROR) << "TestingAutomationProvider::Login";
On 2012/06/07 00:30:55, Nirnimesh wrote:
> Login->StartLogin
> 
> Why LOG(ERROR)?

No idea, this hook is nearly a direct revert. I'll change it to something more
reasonable.

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider_chromeos.cc:303:
LOG(ERROR) << "TestingAutomationProvider::Login ShowSigninScreenForCreds("
On 2012/06/07 00:30:55, Nirnimesh wrote:
> Use VLOG(2)

Done.

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:88: from pyauto_errors import LoginError
On 2012/06/07 00:30:55, Nirnimesh wrote:
> remove?

Done.

https://chromiumcodereview.appspot.com/10533038/diff/3001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:4121: will not be noticed here, because the
browser has no knowledge of it.
On 2012/06/07 00:30:55, Nirnimesh wrote:
> Add: All such scenarios will lead to timeout of the Login() call

Done.

[Nirnimesh, 2012-06-07 19:17:04]

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.h (right):

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:1342: void
StartLogin(base::DictionaryValue* args, IPC::Message* reply_message);
It's not obvious what StartLogin does. Please document it.

How about renaming it to SubmitLoginForm so that it's intention is a bit
clearer?

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (left):

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:88: from pyauto_errors import LoginError
Also remove LoginError from pyauto_errors?

[craigdh, 2012-06-07 23:16:51]

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.h (right):

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:1342: void
StartLogin(base::DictionaryValue* args, IPC::Message* reply_message);
On 2012/06/07 19:17:04, Nirnimesh wrote:
> It's not obvious what StartLogin does. Please document it.
> 
> How about renaming it to SubmitLoginForm so that it's intention is a bit
> clearer?

Done. Renamed and added documentation.

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (left):

https://chromiumcodereview.appspot.com/10533038/diff/5002/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:88: from pyauto_errors import LoginError
On 2012/06/07 19:17:04, Nirnimesh wrote:
> Also remove LoginError from pyauto_errors?

Done.

[Nirnimesh, 2012-06-07 23:21:21]

LGTM

[commit-bot: I haz the power, 2012-06-08 16:41:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10533038/9001

[commit-bot: I haz the power, 2012-06-08 18:51:46]

Change committed as 141247