Switch back to the old method of launching the login flow while keeping some of the benefits of the…

chrome/browser/automation/testing_automation_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_
 #define CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 1321 matching lines @@
 
 #if defined(OS_CHROMEOS)
   // Login / Logout.
   void GetLoginInfo(base::DictionaryValue* args, IPC::Message* reply_message);
 
   void ShowCreateAccountUI(base::DictionaryValue* args,
                            IPC::Message* reply_message);
 
   void LoginAsGuest(base::DictionaryValue* args, IPC::Message* reply_message);
 
+  void StartLogin(base::DictionaryValue* args, IPC::Message* reply_message);

[Nirnimesh, 2012/06/07 19:17:04]

It's not obvious what StartLogin does. Please document it.

How about renaming it to SubmitLoginForm so that it's intention is a bit
clearer?

[craigdh, 2012/06/07 23:16:52]

Done. Renamed and added documentation.

+
   void AddLoginEventObserver(DictionaryValue* args,
                              IPC::Message* reply_message);
 
   // Executes javascript in the specified frame in the OOBE WebUI on chromeos.
   // Waits for a result from the |DOMAutomationController|. The javascript must
   // send a string. Must be run before a user has logged in.
   // Example:
   //   input: { "frame_xpath": "//frames[1]",
   //            "javascript":
   //                "window.domAutomationController.send(window.name)",
@@ skipping 148 matching lines @@
   ImportSettingsData import_settings_data_;
 
   // The automation event observer queue. It is lazily created when an observer
   // is added to avoid overhead when not needed.
   scoped_ptr<AutomationEventQueue> automation_event_queue_;
 
   DISALLOW_COPY_AND_ASSIGN(TestingAutomationProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_TESTING_AUTOMATION_PROVIDER_H_