chrome/test/functional/chromeos_login.py - Issue 10533038: Switch back to the old method of launching the login flow while keeping some of the benefits of the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/chromeos_login.py

Issue 10533038: Switch back to the old method of launching the login flow while keeping some of the benefits of the… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Nirnimesh's comments and fixed chromeos_login.py to work with these changes. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/functional/chromeos_login.py

diff --git a/chrome/test/functional/chromeos_login.py b/chrome/test/functional/chromeos_login.py

index 3925ba70547ee4495f45b171fd221f37d986fbf0..bd27f229f9cca8643cc9cf92ba3cc289ea680cff 100755

--- a/chrome/test/functional/chromeos_login.py

+++ b/chrome/test/functional/chromeos_login.py

@@ -55,7 +55,7 @@ class ChromeosLogin(pyauto.PyUITest):

def testBadUsername(self):

"""Test that login fails when passed an invalid username."""

self.assertRaises(

- pyauto_errors.LoginError,

+ pyauto_errors.JSONInterfaceError,

lambda: self.Login('doesnotexist@fakedomain.org', 'badpassword'))

login_info = self.GetLoginInfo()

self.assertFalse(login_info['is_logged_in'],

@@ -65,7 +65,7 @@ class ChromeosLogin(pyauto.PyUITest):

"""Test that login fails when passed an invalid password."""

credentials = self._ValidCredentials()

self.assertRaises(

- pyauto_errors.LoginError,

+ pyauto_errors.JSONInterfaceError,

lambda: self.Login(credentials['username'], 'badpassword'))

login_info = self.GetLoginInfo()

self.assertFalse(login_info['is_logged_in'],

« no previous file with comments | « chrome/browser/automation/testing_automation_provider_chromeos.cc ('k') | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »