Issue 10512019: Merge 138001 - Fix the alignment issue with Arabic when a font has kerning or cursive gsub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10512019: Merge 138001 - Fix the alignment issue with Arabic when a font has kerning or cursive gsub (Closed)

Created:
8 years, 6 months ago by jungshik at Google

Modified:
8 years, 6 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1132/src/

Visibility:
Public.

Merge 138001 - Fix the alignment issue with Arabic when a font has kerning or cursive gsub Patch by behdad@chromium.org. Will add a webkit layout test for Arabic alignment as soon as we find a font that can be included in Webkit LayoutTests. BUG=105685 TEST= http://www.bbcarabic.com should be rendered the same way as is done by Firefox on Linux. Paragraphs should be right justified and should not overlap with photos or other elements next to them. See the screenshots attached in the bug report. TBR=bashik Review URL: https://chromiumcodereview.appspot.com/10382212 TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140371

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -6 lines)			Patch
M	third_party/harfbuzz/README.chromium	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/harfbuzz/chromium.patch	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	third_party/harfbuzz/src/harfbuzz-shaper.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)