Fix the alignment issue with Arabic when a font has kerning or cursive gsub.

Fix the alignment issue with Arabic when a font has kerning or cursive gsub 

Patch by behdad@chromium.org.



Will add a webkit layout test for Arabic alignment as soon as we find
a font that can be included in Webkit LayoutTests.

BUG=105685
TEST= http://www.bbcarabic.com should be rendered the same way as is done by Firefox on Linux. Paragraphs should be right justified and should not overlap with photos or other elements next to them.  See the screenshots attached in the bug report.
TBR=bashik

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138001

[behdad, 2012-05-17 22:04:24]

lgtm

[commit-bot: I haz the power, 2012-05-17 22:05:27]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jungshik at Google, 2012-05-18 06:25:45]

@bashi, can you review this change? (Apparently, behdad pressed 'commit' button
(because he's so eager to see this change integrated) after giving me LGTM. 

BTW, I considered going all the way to the latest harfbuzz-old, but there's an
issue I'm still investigating. So, in the meantime, let's fix this issue first
before updating to the latest. Of course, if we can go to harfbuzz-ng now, it'd
be even better.

[Hironori Bono, 2012-05-18 06:33:50]

Greetings Jungshik,

Unfortunately, bashi has been involved a car accident and I wonder if he can
review this change in the near future. (I do not have any details now.)

Regards,

Hironori Bono

On 2012/05/18 06:25:45, Jungshik Shin wrote:
> @bashi, can you review this change? (Apparently, behdad pressed 'commit'
button
> (because he's so eager to see this change integrated) after giving me LGTM. 
> 
> BTW, I considered going all the way to the latest harfbuzz-old, but there's an
> issue I'm still investigating. So, in the meantime, let's fix this issue first
> before updating to the latest. Of course, if we can go to harfbuzz-ng now,
it'd
> be even better.

[jungshik at Google, 2012-05-18 17:15:44]

Hi Hironori, 

Thank you for the note. The actual change was made by Behdad (the author of
harfbuzz). So, if you can LGTM this CL, it'll be great, too. 

I hope everything will turn out all right for bashi. 




On 2012/05/18 06:33:50, Hironori Bono wrote:
> Greetings Jungshik,
> 
> Unfortunately, bashi has been involved a car accident and I wonder if he can
> review this change in the near future. (I do not have any details now.)
> 
> Regards,
> 
> Hironori Bono
> 
> On 2012/05/18 06:25:45, Jungshik Shin wrote:
> > @bashi, can you review this change? (Apparently, behdad pressed 'commit'
> button
> > (because he's so eager to see this change integrated) after giving me LGTM. 
> > 
> > BTW, I considered going all the way to the latest harfbuzz-old, but there's
an
> > issue I'm still investigating. So, in the meantime, let's fix this issue
first
> > before updating to the latest. Of course, if we can go to harfbuzz-ng now,
> it'd
> > be even better.

[jungshik at Google, 2012-05-18 23:43:47]

This is just landing a patch by the lead developer of Harfbuzz. So, I'll just
use TBR=bashi. 


On 2012/05/18 17:15:44, Jungshik Shin wrote:
> Hi Hironori, 
> 
> Thank you for the note. The actual change was made by Behdad (the author of
> harfbuzz). So, if you can LGTM this CL, it'll be great, too. 
> 
> I hope everything will turn out all right for bashi. 
> 
> 
> 
> 
> On 2012/05/18 06:33:50, Hironori Bono wrote:
> > Greetings Jungshik,
> > 
> > Unfortunately, bashi has been involved a car accident and I wonder if he can
> > review this change in the near future. (I do not have any details now.)
> > 
> > Regards,
> > 
> > Hironori Bono
> > 
> > On 2012/05/18 06:25:45, Jungshik Shin wrote:
> > > @bashi, can you review this change? (Apparently, behdad pressed 'commit'
> > button
> > > (because he's so eager to see this change integrated) after giving me
LGTM. 
> > > 
> > > BTW, I considered going all the way to the latest harfbuzz-old, but
there's
> an
> > > issue I'm still investigating. So, in the meantime, let's fix this issue
> first
> > > before updating to the latest. Of course, if we can go to harfbuzz-ng now,
> > it'd
> > > be even better.

[commit-bot: I haz the power, 2012-05-18 23:44:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jshin@chromium.org/10382212/6001

[commit-bot: I haz the power, 2012-05-19 01:04:35]

Change committed as 138001