Issue 10496010: Updated SigninManager and TokenService to generate notifications at signout.

Issue 10496010: Updated SigninManager and TokenService to generate notifications at signout. (Closed)

Created:
8 years, 6 months ago by Andrew T Wilson (Slow)

Modified:
8 years, 6 months ago

Reviewers:
James Hawkins, Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated SigninManager and TokenService to generate notifications at signout. This ensures that sync is disabled if the currently signed-in user becomes disallowed due to policy changes. BUG=128831 TEST=sign out, make sure sync shuts down Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140318

Patch Set 1 #

Patch Set 2 : Simplify cros code in SyncSetupHandler. #

Total comments: 2

Patch Set 3 : Fixed comment per review. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
M	chrome/browser/signin/signin_manager.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/signin/token_service.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 2	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

Roger: PTAL jhawkins: Can you provide your owners rubberstamp for the change to sync_setup_handler.cc?

8 years, 6 months ago (2012-06-02 21:32:43 UTC) #1

Roger Tawa OOO till Jul 10th

lgtm, one comment nit below. http://codereview.chromium.org/10496010/diff/6001/chrome/browser/ui/webui/sync_setup_handler.cc File chrome/browser/ui/webui/sync_setup_handler.cc (right): http://codereview.chromium.org/10496010/diff/6001/chrome/browser/ui/webui/sync_setup_handler.cc#newcode873 chrome/browser/ui/webui/sync_setup_handler.cc:873: // platforms. nit: the ...

8 years, 6 months ago (2012-06-04 13:43:40 UTC) #2

Andrew T Wilson (Slow)

http://codereview.chromium.org/10496010/diff/6001/chrome/browser/ui/webui/sync_setup_handler.cc File chrome/browser/ui/webui/sync_setup_handler.cc (right): http://codereview.chromium.org/10496010/diff/6001/chrome/browser/ui/webui/sync_setup_handler.cc#newcode873 chrome/browser/ui/webui/sync_setup_handler.cc:873: // platforms. On 2012/06/04 13:43:40, Roger Tawa wrote: > ...

8 years, 6 months ago (2012-06-04 16:06:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/10496010/13002

8 years, 6 months ago (2012-06-04 16:12:02 UTC) #5

Change committed as 140318

Expand Messages | Collapse Messages