Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6601)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 10496010: Updated SigninManager and TokenService to generate notifications at signout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment per review. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/common/chrome_notification_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc
index 44dcb5bffc3f48d2d00d255ca165dce3dfb58d38..7e53b8e6a26d9542fc9482d28f7d27058f7b29e5 100644
--- a/chrome/browser/ui/webui/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler.cc
@@ -869,11 +869,13 @@ void SyncSetupHandler::CloseSyncSetup() {
// and shut down sync.
if (sync_service && !sync_service->HasSyncSetupCompleted()) {
DVLOG(1) << "Signin aborted by user action";
+ // Calling DisableForUser() will also sign the user out on desktop
+ // platforms (platforms without sync auto-start enabled).
sync_service->DisableForUser();
-#if !defined(OS_CHROMEOS)
- GetSignin()->SignOut();
-#else
- // TODO(atwilson): Move this suppression to PSS::DisableForUser()
+
+#if defined(OS_CHROMEOS)
+ // Suppress sync startup on ChromeOS, so it doesn't get restarted when
+ // the user logs in again.
browser_sync::SyncPrefs sync_prefs(GetProfile()->GetPrefs());
sync_prefs.SetStartSuppressed(true);
#endif
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/common/chrome_notification_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698