Fix inconsistency in browser shortcut handling when a BrowserAction popup is focused.

Fix inconsistency in browser shortcut handling when a BrowserAction popup is focused.

Current behavior:

* Windows: Cannot use all browser shortcuts.
* Mac: Can use all browser shortcuts.
* Chrome OS (-M20): Cannot use all browser shortcuts. Can use Ash shortcuts.
* Chrome OS (M21): Cannot use all browser shortcuts. Cannot use Ash shortcuts (crbug.com/130131).

New behavior:

* All platforms: Can use all browser shortcuts. Can also use Ash shortcuts if the platform supports Ash.

BUG=130131
TEST=Confirmed C-n, C-t, C-w, and C-f worked as expected

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141169

[Yusuke Sato, 2012-06-01 06:54:06]

Ben, could you review this change?

[Ben Goodger (Google), 2012-06-01 17:15:18]

replacing myself with aa

[Yusuke Sato, 2012-06-06 14:10:17]

Aaron, could you review this? I would like to fix crbug.com/130131 before M21
branch is created.

[Aaron Boodman, 2012-06-06 18:17:04]

LGTM, but...

I am not that familiar with keyboard handling. If you are confident in this
change, I would go ahead and land it. If you would like someone more experienced
to take a look , I might suggest finnur@ or sky@.

Sorry I couldn't be more help.

[Yusuke Sato, 2012-06-07 06:15:49]

+sky

Thanks. It turned out chrome/browser/ui/OWNERS' review was needed anyway. Scott,
could you take a look?

On 2012/06/06 18:17:04, Aaron Boodman wrote:
> LGTM, but...
> 
> I am not that familiar with keyboard handling. If you are confident in this
> change, I would go ahead and land it. If you would like someone more
experienced
> to take a look , I might suggest finnur@ or sky@.
> 
> Sorry I couldn't be more help.

[sky, 2012-06-07 17:28:22]

Move the implementation to match, and LGTM

[commit-bot: I haz the power, 2012-06-08 01:54:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10459044/13001

[commit-bot: I haz the power, 2012-06-08 04:49:26]

Change committed as 141169

[Yusuke Sato, 2012-06-09 06:36:39]

On 2012/06/07 17:28:22, sky wrote:
> Move the implementation to match

Done.