Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Side by Side Diff: chrome/browser/extensions/extension_host.h

Issue 10459044: Fix inconsistency in browser shortcut handling when a BrowserAction popup is focused. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix, rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 // Message handlers. 190 // Message handlers.
191 void OnRequest(const ExtensionHostMsg_Request_Params& params); 191 void OnRequest(const ExtensionHostMsg_Request_Params& params);
192 void OnEventAck(); 192 void OnEventAck();
193 void OnIncrementLazyKeepaliveCount(); 193 void OnIncrementLazyKeepaliveCount();
194 void OnDecrementLazyKeepaliveCount(); 194 void OnDecrementLazyKeepaliveCount();
195 195
196 // Handles keyboard events that were not handled by HandleKeyboardEvent(). 196 // Handles keyboard events that were not handled by HandleKeyboardEvent().
197 // Platform specific implementation may override this method to handle the 197 // Platform specific implementation may override this method to handle the
198 // event in platform specific way. 198 // event in platform specific way.
199 virtual void UnhandledKeyboardEvent( 199 virtual void UnhandledKeyboardEvent(
200 const content::NativeWebKeyboardEvent& event) {} 200 const content::NativeWebKeyboardEvent& event);
201 201
202 // Returns true if we're hosting a background page. 202 // Returns true if we're hosting a background page.
203 // This isn't valid until CreateRenderView is called. 203 // This isn't valid until CreateRenderView is called.
204 bool is_background_page() const { return !view(); } 204 bool is_background_page() const { return !view(); }
205 205
206 // The extension that we're hosting in this view. 206 // The extension that we're hosting in this view.
207 const extensions::Extension* extension_; 207 const extensions::Extension* extension_;
208 208
209 // Id of extension that we're hosting in this view. 209 // Id of extension that we're hosting in this view.
210 const std::string extension_id_; 210 const std::string extension_id_;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 // The relevant WebContents associated with this ExtensionHost, if any. 250 // The relevant WebContents associated with this ExtensionHost, if any.
251 content::WebContents* associated_web_contents_; 251 content::WebContents* associated_web_contents_;
252 252
253 // Used to measure how long it's been since the host was created. 253 // Used to measure how long it's been since the host was created.
254 PerfTimer since_created_; 254 PerfTimer since_created_;
255 255
256 DISALLOW_COPY_AND_ASSIGN(ExtensionHost); 256 DISALLOW_COPY_AND_ASSIGN(ExtensionHost);
257 }; 257 };
258 258
259 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 259 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698