Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 10459044: Fix inconsistency in browser shortcut handling when a BrowserAction popup is focused. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix, rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 int from_index, 788 int from_index,
789 int to_index) OVERRIDE; 789 int to_index) OVERRIDE;
790 virtual void TabReplacedAt(TabStripModel* tab_strip_model, 790 virtual void TabReplacedAt(TabStripModel* tab_strip_model,
791 TabContents* old_contents, 791 TabContents* old_contents,
792 TabContents* new_contents, 792 TabContents* new_contents,
793 int index) OVERRIDE; 793 int index) OVERRIDE;
794 virtual void TabPinnedStateChanged(TabContents* contents, 794 virtual void TabPinnedStateChanged(TabContents* contents,
795 int index) OVERRIDE; 795 int index) OVERRIDE;
796 virtual void TabStripEmpty() OVERRIDE; 796 virtual void TabStripEmpty() OVERRIDE;
797 797
798 // Overridden from content::WebContentsDelegate:
799 virtual bool PreHandleKeyboardEvent(
800 const content::NativeWebKeyboardEvent& event,
801 bool* is_keyboard_shortcut) OVERRIDE;
802 virtual void HandleKeyboardEvent(
803 const content::NativeWebKeyboardEvent& event) OVERRIDE;
804
798 // Fullscreen permission infobar callbacks. 805 // Fullscreen permission infobar callbacks.
799 // TODO(koz): Remove this and have callers call FullscreenController directly. 806 // TODO(koz): Remove this and have callers call FullscreenController directly.
800 void OnAcceptFullscreenPermission(const GURL& url, 807 void OnAcceptFullscreenPermission(const GURL& url,
801 FullscreenExitBubbleType bubble_type); 808 FullscreenExitBubbleType bubble_type);
802 void OnDenyFullscreenPermission(FullscreenExitBubbleType bubble_type); 809 void OnDenyFullscreenPermission(FullscreenExitBubbleType bubble_type);
803 810
804 // Figure out if there are tabs that have beforeunload handlers. 811 // Figure out if there are tabs that have beforeunload handlers.
805 bool TabsNeedBeforeUnloadFired(); 812 bool TabsNeedBeforeUnloadFired();
806 813
807 bool is_type_tabbed() const { return type_ == TYPE_TABBED; } 814 bool is_type_tabbed() const { return type_ == TYPE_TABBED; }
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 virtual void RenderWidgetShowing() OVERRIDE; 932 virtual void RenderWidgetShowing() OVERRIDE;
926 virtual int GetExtraRenderViewHeight() const OVERRIDE; 933 virtual int GetExtraRenderViewHeight() const OVERRIDE;
927 virtual void OnStartDownload(content::WebContents* source, 934 virtual void OnStartDownload(content::WebContents* source,
928 content::DownloadItem* download) OVERRIDE; 935 content::DownloadItem* download) OVERRIDE;
929 virtual void ViewSourceForTab(content::WebContents* source, 936 virtual void ViewSourceForTab(content::WebContents* source,
930 const GURL& page_url) OVERRIDE; 937 const GURL& page_url) OVERRIDE;
931 virtual void ViewSourceForFrame( 938 virtual void ViewSourceForFrame(
932 content::WebContents* source, 939 content::WebContents* source,
933 const GURL& frame_url, 940 const GURL& frame_url,
934 const std::string& frame_content_state) OVERRIDE; 941 const std::string& frame_content_state) OVERRIDE;
935 virtual bool PreHandleKeyboardEvent(
936 const content::NativeWebKeyboardEvent& event,
937 bool* is_keyboard_shortcut) OVERRIDE;
938 virtual void HandleKeyboardEvent(
939 const content::NativeWebKeyboardEvent& event) OVERRIDE;
940 virtual void ShowRepostFormWarningDialog( 942 virtual void ShowRepostFormWarningDialog(
941 content::WebContents* source) OVERRIDE; 943 content::WebContents* source) OVERRIDE;
942 virtual bool ShouldAddNavigationToHistory( 944 virtual bool ShouldAddNavigationToHistory(
943 const history::HistoryAddPageArgs& add_page_args, 945 const history::HistoryAddPageArgs& add_page_args,
944 content::NavigationType navigation_type) OVERRIDE; 946 content::NavigationType navigation_type) OVERRIDE;
945 virtual bool ShouldCreateWebContents( 947 virtual bool ShouldCreateWebContents(
946 content::WebContents* web_contents, 948 content::WebContents* web_contents,
947 int route_id, 949 int route_id,
948 WindowContainerType window_container_type, 950 WindowContainerType window_container_type,
949 const string16& frame_name, 951 const string16& frame_name,
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
1428 bool window_has_shown_; 1430 bool window_has_shown_;
1429 1431
1430 // Currently open color chooser. Non-NULL after OpenColorChooser is called and 1432 // Currently open color chooser. Non-NULL after OpenColorChooser is called and
1431 // before DidEndColorChooser is called. 1433 // before DidEndColorChooser is called.
1432 scoped_ptr<content::ColorChooser> color_chooser_; 1434 scoped_ptr<content::ColorChooser> color_chooser_;
1433 1435
1434 DISALLOW_COPY_AND_ASSIGN(Browser); 1436 DISALLOW_COPY_AND_ASSIGN(Browser);
1435 }; 1437 };
1436 1438
1437 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1439 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698