Issue 10449026: Fixing leftover from prior reveiew, plus more lint.

Issue 10449026: Fixing leftover from prior reveiew, plus more lint. (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixing leftover from prior reveiew, plus more lint. Prior review: https://chromiumcodereview.appspot.com/10399131/ Fixing more lint warnings. BUG=None TEST=None R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1394

Patch Set 5 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1224 lines, -1222 lines)			Patch
M	PRESUBMIT.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	pylib/gyp/MSVSNew.py	View	1 2 3 4	2 chunks	+2 lines, -3 lines	0 comments	Download
M	pylib/gyp/MSVSProject.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pylib/gyp/MSVSToolFile.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pylib/gyp/MSVSUserFile.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pylib/gyp/SCons.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pylib/gyp/common.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pylib/gyp/generator/make.py	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	pylib/gyp/generator/ninja.py	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	pylib/gyp/input.py	View	1	5 chunks	+1 line, -6 lines	0 comments	Download
M	test/variables/commands/commands-repeated.gyp.stdout	View	1 2 3	1 chunk	+438 lines, -438 lines	0 comments	Download
M	test/variables/commands/commands.gyp.stdout	View	1 2 3	1 chunk	+283 lines, -283 lines	0 comments	Download
M	test/variables/commands/commands.gyp.ignore-env.stdout	View	1 2 3	1 chunk	+283 lines, -283 lines	0 comments	Download
M	test/variables/filelist/filelist.gyp.stdout	View	1 2 3	1 chunk	+195 lines, -195 lines	0 comments	Download
M	tools/pretty_gyp.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10449026/diff/2001/pylib/gyp/common.py File pylib/gyp/common.py (right): https://chromiumcodereview.appspot.com/10449026/diff/2001/pylib/gyp/common.py#newcode396 pylib/gyp/common.py:396: idfun = ident_idfun idfun = lamba x: x https://chromiumcodereview.appspot.com/10449026/diff/2001/pylib/gyp/generator/make.py ...

8 years, 7 months ago (2012-05-25 19:34:48 UTC) #2

bradn

PTAL https://chromiumcodereview.appspot.com/10449026/diff/2001/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (left): https://chromiumcodereview.appspot.com/10449026/diff/2001/pylib/gyp/generator/make.py#oldcode82 pylib/gyp/generator/make.py:82: global COMPILABLE_EXTENSIONS On 2012/05/25 19:34:49, Nico wrote: > ...

8 years, 7 months ago (2012-05-25 19:42:31 UTC) #3

lgtm

Expand Messages | Collapse Messages