Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Side by Side Diff: PRESUBMIT.py

Issue 10449026: Fixing leftover from prior reveiew, plus more lint. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pylib/gyp/MSVSNew.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 """Top-level presubmit script for GYP. 6 """Top-level presubmit script for GYP.
7 7
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
9 for more details about the presubmit API built into gcl. 9 for more details about the presubmit API built into gcl.
10 """ 10 """
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 # Undefined variable. 52 # Undefined variable.
53 'E0602', 53 'E0602',
54 # Not exception type specified. 54 # Not exception type specified.
55 'W0702', 55 'W0702',
56 # No member of that name. 56 # No member of that name.
57 'E1101', 57 'E1101',
58 # Dangerous default {}. 58 # Dangerous default {}.
59 'W0102', 59 'W0102',
60 # Others, too many to sort. 60 # Others, too many to sort.
61 'W0201', 'W0232', 'E1103', 'W0621', 'W0108', 'W0223', 'W0231', 61 'W0201', 'W0232', 'E1103', 'W0621', 'W0108', 'W0223', 'W0231',
62 'R0201', 'E0101', 'C0321', 'W0602', 'W0631', 'W0601', 'W0701', 62 'R0201', 'E0101', 'C0321',
63 'E0102', 'W0221', 'W0403',
64 ] 63 ]
65 64
66 65
67 def CheckChangeOnUpload(input_api, output_api): 66 def CheckChangeOnUpload(input_api, output_api):
68 report = [] 67 report = []
69 report.extend(input_api.canned_checks.PanProjectChecks( 68 report.extend(input_api.canned_checks.PanProjectChecks(
70 input_api, output_api)) 69 input_api, output_api))
71 return report 70 return report
72 71
73 72
(...skipping 24 matching lines...) Expand all
98 output_api, 97 output_api,
99 black_list=PYLINT_BLACKLIST, 98 black_list=PYLINT_BLACKLIST,
100 disabled_warnings=PYLINT_DISABLED_WARNINGS)) 99 disabled_warnings=PYLINT_DISABLED_WARNINGS))
101 finally: 100 finally:
102 sys.path = old_sys_path 101 sys.path = old_sys_path
103 return report 102 return report
104 103
105 104
106 def GetPreferredTrySlaves(): 105 def GetPreferredTrySlaves():
107 return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac'] 106 return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac']
OLDNEW
« no previous file with comments | « no previous file | pylib/gyp/MSVSNew.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698