Issue 10399131: Fixing pylint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399131: Fixing pylint. (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
8 years, 7 months ago

Reviewers:
Nico, M-A Ruel

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Made stab at fixing pylint warnings, supressing the rest. BUG=None TEST=None R=thakis@chromium.org,maruel@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1392

Patch Set 3 : #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -46 lines)			Patch
M	PRESUBMIT.py	View		3 chunks	+58 lines, -2 lines	0 comments	Download
M	test/mac/gyptest-rebuild.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mac/gyptest-strip.py	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	test/make/gyptest-dependencies.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/msvs/props/gyptest-props.py	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	test/subdirectory/gyptest-subdir-all.py	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	test/variables/commands/gyptest-commands-repeated.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
MM	tools/pretty_gyp.py	View	1 2	2 chunks	+4 lines, -2 lines	1 comment	Download
M	tools/pretty_sln.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/pretty_vcproj.py	View		6 chunks	+28 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10399131/diff/20/tools/pretty_gyp.py File tools/pretty_gyp.py (right): https://chromiumcodereview.appspot.com/10399131/diff/20/tools/pretty_gyp.py#newcode2 tools/pretty_gyp.py:2: #!/usr/bin/env python This looks wrong.

8 years, 7 months ago (2012-05-23 16:45:00 UTC) #3

Will fix in follow on.

Expand Messages | Collapse Messages

Issue 10399131: Fixing pylint. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages