Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 10449010: Fix the extension activity log UI. (Closed)

Created:
8 years, 7 months ago by Eric Dingle
Modified:
8 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix the extension activity log UI. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139836

Patch Set 1 #

Patch Set 2 : Patch Set 2 #

Total comments: 4

Patch Set 3 : Address Evan's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M chrome/browser/resources/extensions/extension_activity.html View 1 2 2 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/resources/extensions/extension_activity.js View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_activity_ui.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Eric Dingle
8 years, 6 months ago (2012-05-28 20:54:36 UTC) #1
Eric Dingle
On 2012/05/28 20:54:36, Eric Dingle wrote: Ping.
8 years, 6 months ago (2012-05-29 20:13:34 UTC) #2
Evan Stade
http://codereview.chromium.org/10449010/diff/2001/chrome/browser/resources/extensions/extension_activity.html File chrome/browser/resources/extensions/extension_activity.html (right): http://codereview.chromium.org/10449010/diff/2001/chrome/browser/resources/extensions/extension_activity.html#newcode10 chrome/browser/resources/extensions/extension_activity.html:10: <link rel="stylesheet" href="../uber/uber_shared.css"> why did you add this? the ...
8 years, 6 months ago (2012-05-29 22:12:38 UTC) #3
Eric Dingle
http://codereview.chromium.org/10449010/diff/2001/chrome/browser/resources/extensions/extension_activity.html File chrome/browser/resources/extensions/extension_activity.html (right): http://codereview.chromium.org/10449010/diff/2001/chrome/browser/resources/extensions/extension_activity.html#newcode10 chrome/browser/resources/extensions/extension_activity.html:10: <link rel="stylesheet" href="../uber/uber_shared.css"> On 2012/05/29 22:12:38, Evan Stade wrote: ...
8 years, 6 months ago (2012-05-30 14:13:37 UTC) #4
Evan Stade
lgtm
8 years, 6 months ago (2012-05-30 21:02:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericdingle@chromium.org/10449010/4003
8 years, 6 months ago (2012-05-31 13:50:51 UTC) #6
commit-bot: I haz the power
Try job failure for 10449010-4003 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-05-31 16:46:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericdingle@chromium.org/10449010/4003
8 years, 6 months ago (2012-05-31 17:09:45 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 19:18:38 UTC) #9
Change committed as 139836

Powered by Google App Engine
This is Rietveld 408576698