Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_activity_ui.cc

Issue 10449010: Fix the extension activity log UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Evan's comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_activity_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extension_activity_ui.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 10 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
(...skipping 14 matching lines...) Expand all
25 25
26 ChromeWebUIDataSource* source = 26 ChromeWebUIDataSource* source =
27 new ChromeWebUIDataSource(chrome::kChromeUIExtensionActivityHost); 27 new ChromeWebUIDataSource(chrome::kChromeUIExtensionActivityHost);
28 28
29 // Localized strings. 29 // Localized strings.
30 source->AddLocalizedString("extensionActivity", IDS_EXTENSION_ACTIVITY_TITLE); 30 source->AddLocalizedString("extensionActivity", IDS_EXTENSION_ACTIVITY_TITLE);
31 source->AddLocalizedString("extensionActivityApiCall", 31 source->AddLocalizedString("extensionActivityApiCall",
32 IDS_EXTENSION_ACTIVITY_API_CALL); 32 IDS_EXTENSION_ACTIVITY_API_CALL);
33 source->AddLocalizedString("extensionActivityApiBlock", 33 source->AddLocalizedString("extensionActivityApiBlock",
34 IDS_EXTENSION_ACTIVITY_API_BLOCK); 34 IDS_EXTENSION_ACTIVITY_API_BLOCK);
35 source->set_use_json_js_format_v2();
35 source->set_json_path("strings.js"); 36 source->set_json_path("strings.js");
36 37
37 // Resources. 38 // Resources.
38 source->add_resource_path("extension_activity.js", IDR_EXTENSION_ACTIVITY_JS); 39 source->add_resource_path("extension_activity.js", IDR_EXTENSION_ACTIVITY_JS);
39 source->set_default_resource(IDR_EXTENSION_ACTIVITY_HTML); 40 source->set_default_resource(IDR_EXTENSION_ACTIVITY_HTML);
40 41
42 Profile* profile = Profile::FromWebUI(web_ui);
43 ChromeURLDataManager::AddDataSource(profile, source);
44 ChromeURLDataManager::AddDataSource(profile, new SharedResourcesDataSource());
45
41 // Callback handlers. 46 // Callback handlers.
42 web_ui->RegisterMessageCallback("requestExtensionData", 47 web_ui->RegisterMessageCallback("requestExtensionData",
43 base::Bind(&ExtensionActivityUI::HandleRequestExtensionData, 48 base::Bind(&ExtensionActivityUI::HandleRequestExtensionData,
44 base::Unretained(this))); 49 base::Unretained(this)));
45
46 Profile* profile = Profile::FromWebUI(web_ui);
47 ChromeURLDataManager::AddDataSource(profile, source);
48 ChromeURLDataManager::AddDataSource(profile, new SharedResourcesDataSource());
49 } 50 }
50 51
51 ExtensionActivityUI::~ExtensionActivityUI() { 52 ExtensionActivityUI::~ExtensionActivityUI() {
52 if (extension_) 53 if (extension_)
53 ExtensionActivityLog::GetInstance()->RemoveObserver(extension_, this); 54 ExtensionActivityLog::GetInstance()->RemoveObserver(extension_, this);
54 } 55 }
55 56
56 void ExtensionActivityUI::HandleRequestExtensionData( 57 void ExtensionActivityUI::HandleRequestExtensionData(
57 const base::ListValue* args) { 58 const base::ListValue* args) {
58 DCHECK_EQ(1U, args->GetSize()); 59 DCHECK_EQ(1U, args->GetSize());
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 void ExtensionActivityUI::OnExtensionActivity( 93 void ExtensionActivityUI::OnExtensionActivity(
93 const extensions::Extension* extension, 94 const extensions::Extension* extension,
94 ExtensionActivityLog::Activity activity, 95 ExtensionActivityLog::Activity activity,
95 const std::string& msg) { 96 const std::string& msg) {
96 DictionaryValue result; 97 DictionaryValue result;
97 result.SetInteger("activity", activity); 98 result.SetInteger("activity", activity);
98 result.SetString("message", msg); 99 result.SetString("message", msg);
99 web_ui()->CallJavascriptFunction("extension_activity.handleExtensionActivity", 100 web_ui()->CallJavascriptFunction("extension_activity.handleExtensionActivity",
100 result); 101 result);
101 } 102 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698