Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 10449010: Fix the extension activity log UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Evan's comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 01dc1177aebfa3531f5e6e3c62410d045d7788d6..d1a473bbcb417395db6db5afae42323c4a17d2ba 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -132,8 +132,18 @@ cr.define('options', function() {
if (extension.allow_activity) {
var activity = node.querySelector('.activity-link');
- activity.href = 'chrome://extension-activity?extensionId=' +
- extension.id;
+ activity.addEventListener('click', function(e) {
+ chrome.send('navigateToUrl', [
+ 'chrome://extension-activity?extensionId=' + extension.id,
+ '_blank',
+ e.button,
+ e.altKey,
+ e.ctrlKey,
+ e.metaKey,
+ e.shiftKey
+ ]);
+ e.preventDefault();
+ });
activity.hidden = false;
}
« no previous file with comments | « chrome/browser/resources/extensions/extension_activity.js ('k') | chrome/browser/ui/webui/extensions/extension_activity_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698