Issue 10446080: Address review comments from https://chromiumcodereview.appspot.com/10454049/.

Issue 10446080: Address review comments from https://chromiumcodereview.appspot.com/10454049/. (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address review comments from https://chromiumcodereview.appspot.com/10454049/. Committed: https://code.google.com/p/dart/source/detail?r=8143

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/closure.dart	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/validate.dart	View	1	4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

STV! http://codereview.chromium.org/10446080/diff/1/lib/compiler/implementation/ssa/validate.dart File lib/compiler/implementation/ssa/validate.dart (right): http://codereview.chromium.org/10446080/diff/1/lib/compiler/implementation/ssa/validate.dart#newcode86 lib/compiler/implementation/ssa/validate.dart:86: // Make sure the blocks of the parameters ...

8 years, 6 months ago (2012-05-31 07:11:58 UTC) #2

ngeoffray

8 years, 6 months ago (2012-05-31 08:16:16 UTC) #3

Thanks Lasse!

http://codereview.chromium.org/10446080/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/validate.dart (right):

http://codereview.chromium.org/10446080/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/validate.dart:86: // Make sure the blocks of the
parameters of a phi are dominating the
On 2012/05/31 07:11:58, Lasse Reichstein Nielsen wrote:
> Pedantry: "Make sure" -> "Check that". If you "make sure", you are willing to
> change something to make it so. If you merely check it, the check can fail.
> Ditto below.

Done.

http://codereview.chromium.org/10446080/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/validate.dart:87: // corresponding predecessor
block. Note that block dominates
On 2012/05/31 07:11:58, Lasse Reichstein Nielsen wrote:
> "block dominates" -> "blocks dominate" (or "a block dominates itself").

Done.

Expand Messages | Collapse Messages