Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10446080: Address review comments from https://chromiumcodereview.appspot.com/10454049/. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/closure.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class Interceptors { 5 class Interceptors {
6 Compiler compiler; 6 Compiler compiler;
7 Interceptors(Compiler this.compiler); 7 Interceptors(Compiler this.compiler);
8 8
9 SourceString mapOperatorToMethodName(Operator op) { 9 SourceString mapOperatorToMethodName(Operator op) {
10 String name = op.source.stringValue; 10 String name = op.source.stringValue;
(...skipping 3104 matching lines...) Expand 10 before | Expand all | Expand 10 after
3115 visitCaseMatch(CaseMatch node) { 3115 visitCaseMatch(CaseMatch node) {
3116 compiler.internalError('SsaBuilder.visitCaseMatch'); 3116 compiler.internalError('SsaBuilder.visitCaseMatch');
3117 } 3117 }
3118 3118
3119 visitTryStatement(TryStatement node) { 3119 visitTryStatement(TryStatement node) {
3120 work.allowSpeculativeOptimization = false; 3120 work.allowSpeculativeOptimization = false;
3121 // Save the current locals. The catch block and the finally block 3121 // Save the current locals. The catch block and the finally block
3122 // must not reuse the existing locals handler. None of the variables 3122 // must not reuse the existing locals handler. None of the variables
3123 // that have been defined in the body-block will be used, but for 3123 // that have been defined in the body-block will be used, but for
3124 // loops we will add (unnecessary) phis that will reference the body 3124 // loops we will add (unnecessary) phis that will reference the body
3125 // variables. This will make it look as if the variables were used 3125 // variables. This makes it look as if the variables were used
3126 // in a non-dominated block. 3126 // in a non-dominated block.
3127 LocalsHandler savedLocals = new LocalsHandler.from(localsHandler); 3127 LocalsHandler savedLocals = new LocalsHandler.from(localsHandler);
3128 HBasicBlock enterBlock = openNewBlock(); 3128 HBasicBlock enterBlock = openNewBlock();
3129 HTry tryInstruction = new HTry(); 3129 HTry tryInstruction = new HTry();
3130 List<HBasicBlock> blocks = <HBasicBlock>[]; 3130 List<HBasicBlock> blocks = <HBasicBlock>[];
3131 blocks.add(close(tryInstruction)); 3131 blocks.add(close(tryInstruction));
3132 3132
3133 HBasicBlock tryBody = graph.addNewBlock(); 3133 HBasicBlock tryBody = graph.addNewBlock();
3134 enterBlock.addSuccessor(tryBody); 3134 enterBlock.addSuccessor(tryBody);
3135 open(tryBody); 3135 open(tryBody);
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
3402 <HInstruction>[target, input], 3402 <HInstruction>[target, input],
3403 HType.STRING)); 3403 HType.STRING));
3404 return builder.pop(); 3404 return builder.pop();
3405 } 3405 }
3406 3406
3407 HInstruction result(Node node) { 3407 HInstruction result(Node node) {
3408 flushLiterals(node); 3408 flushLiterals(node);
3409 return prefix; 3409 return prefix;
3410 } 3410 }
3411 } 3411 }
OLDNEW
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/closure.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698