Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: lib/compiler/implementation/ssa/closure.dart

Issue 10446080: Address review comments from https://chromiumcodereview.appspot.com/10454049/. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/closure.dart
===================================================================
--- lib/compiler/implementation/ssa/closure.dart (revision 8142)
+++ lib/compiler/implementation/ssa/closure.dart (working copy)
@@ -100,7 +100,7 @@
final SsaBuilder builder;
final TreeElements elements;
int closureFieldCounter = 0;
- bool inTryCatchOrFinally = false;
+ bool inTryStatement = false;
final Map<Node, ClosureData> closureDataCache;
// Map of captured variables. Initially they will map to themselves. If
@@ -208,7 +208,7 @@
assert(closureData.freeVariableMapping[element] == null ||
closureData.freeVariableMapping[element] == element);
closureData.freeVariableMapping[element] = element;
- } else if (inTryCatchOrFinally) {
+ } else if (inTryStatement) {
// Don't mark the this-element. This would complicate things in the
// builder.
if (element != closureData.thisElement) {
@@ -436,9 +436,9 @@
visitTryStatement(TryStatement node) {
// TODO(ngeoffray): implement finer grain state.
- bool oldInTryCatchOrFinally = inTryCatchOrFinally;
- inTryCatchOrFinally = true;
+ bool oldInTryStatement = inTryStatement;
+ inTryStatement = true;
node.visitChildren(this);
- inTryCatchOrFinally = oldInTryCatchOrFinally;
+ inTryStatement = oldInTryStatement;
}
}
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698