Issue 10446005: Revert half of the changes from 137638 that are probably causing breakages in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446005: Revert half of the changes from 137638 that are probably causing breakages in (Closed)

Created:
8 years, 7 months ago by not at google - send to devlin

Modified:
8 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September), Evan Stade

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert half of the changes from 137638 that are probably causing breakages in the extension updating flow for GTK. The reverted changes are those which make PageActionController only return the visible page actions, rather than returning them all and the UI code hiding any which aren't visible. It occurred to me later that this isn't even a particularly good change, and no longer necessary for why I changed it in the first place. R=mpcomplete@chromium.org TBR=estade@chromium.org BUG=129096, 129193 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138748

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -156 lines)			Patch
D	chrome/browser/extensions/action_box_controller.cc	View		1 chunk	+0 lines, -23 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_helper.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_helper.cc	View		2 chunks	+1 line, -13 lines	0 comments	Download
M	chrome/browser/extensions/page_action_controller.h	View		3 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/page_action_controller.cc	View		3 chunks	+4 lines, -31 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.h	View		6 chunks	+16 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1 2	9 chunks	+84 lines, -55 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

Hey Matt, as I said in the description, this is a half revert. No new ...

8 years, 7 months ago (2012-05-24 00:25:54 UTC) #1

commit-bot: I haz the power

8 years, 7 months ago (2012-05-24 00:34:55 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/10446005/1001

Expand Messages | Collapse Messages